Skip to content

Conversation

@ZenGround0
Copy link
Contributor

@ZenGround0 ZenGround0 commented Oct 21, 2025

  • add direct dependency to ethers to follow best practices ( flushed out while symlinking dev dependency)
  • remove info printout of deprecated field
  • sync the lockup period to match the contract period -- payment rail creation was failing upon add

@BigLep
Copy link
Member

BigLep commented Oct 23, 2025

I assume we'll merge this once:

  1. Next branch FilOzone/synapse-sdk#341 lands
  2. there is a release version with those changes (chore(master): release synapse-sdk 0.35.0 FilOzone/synapse-sdk#342 maybe?)
  3. CI passes
  4. An end-to-end test passes (like the one in feat: add sp health monitor script (DRAFT) #140)

@BigLep BigLep changed the title Updates for moving to the version of synapse-sdk on next branch chore: move to the version of synapse-sdk on next branch Oct 23, 2025
@rvagg
Copy link
Member

rvagg commented Oct 24, 2025

using a published @next tag for Synapse; should work for testing, but there's only 1 test SP in the contracts that were deployed for this so far and there's more breakage to come

@ZenGround0
Copy link
Contributor Author

Now building this linked to of FilOzone/synapse-sdk#355

@BigLep BigLep added team/fs-wg FOC working group is a stakeholder for this work, and thus wants to track it on their project board. team/filecoin-pin "Filecoin Pin" project is a stakeholder for this work. labels Oct 29, 2025
@FilOzzy FilOzzy added this to FS Oct 29, 2025
@github-project-automation github-project-automation bot moved this to 📌 Triage in FS Oct 29, 2025
@BigLep BigLep moved this from 📌 Triage to ⌨️ In Progress in FS Oct 29, 2025
@BigLep
Copy link
Member

BigLep commented Oct 30, 2025

@ZenGround0 : please mark "ready for review" when ready, and @SgtPooki will review

@ZenGround0 ZenGround0 marked this pull request as ready for review October 30, 2025 18:05
Copy link
Collaborator

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nothing crazy in here.

@github-project-automation github-project-automation bot moved this from ⌨️ In Progress to ✔️ Approved by reviewer in FS Oct 30, 2025
@ZenGround0 ZenGround0 merged commit 528c6fa into master Oct 30, 2025
12 checks passed
@ZenGround0 ZenGround0 deleted the next branch October 30, 2025 18:15
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FS Oct 30, 2025
SgtPooki added a commit that referenced this pull request Oct 30, 2025
* Explicitly declare direct dep rather than rely on synapse

* cdn endEpoch removed from ds info

* 10 day grace period => 30 day grace period

* fix: plumb --warm-storage-address through `payments setup`

* fix: check lockup period during allowance check

* chore: update to synapse@next tag, fix test failures & update more lockup mismatches

* post rebase wip

* Update synapse to v0.35.0

* Make things compile with add piece and create all in one

* chore: fix onPieceAdded txHash

* fix test

---------

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
SgtPooki added a commit that referenced this pull request Oct 30, 2025
* fix: check ipni advertisement during upload

* fix: executeUpload only awaits ipniValidationPromise if it exists

* fix: better onProgressTypes

* Update src/core/utils/validate-ipni-advertisement.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/test/unit/validate-ipni-advertisement.test.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/test/unit/validate-ipni-advertisement.test.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update upload-action/src/upload.js

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix(ci): handle duplicate items in add-to-project workflow (#184)

* fix(ci): handle duplicate items in add-to-project workflow

Add continue-on-error to prevent workflow failure when an issue/PR already exists in the project board. The actions/add-to-project action does not currently handle this case gracefully.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix(ci): only run workflow when team/fs-wg label is added

Add conditional to prevent workflow from running on every labeled event. Now it only runs when the specific 'team/fs-wg' label is added, avoiding duplicate runs when multiple labels are added at once.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

* chore: move to the version of synapse-sdk on `next` branch (#146)

* Explicitly declare direct dep rather than rely on synapse

* cdn endEpoch removed from ds info

* 10 day grace period => 30 day grace period

* fix: plumb --warm-storage-address through `payments setup`

* fix: check lockup period during allowance check

* chore: update to synapse@next tag, fix test failures & update more lockup mismatches

* post rebase wip

* Update synapse to v0.35.0

* Make things compile with add piece and create all in one

* chore: fix onPieceAdded txHash

* fix test

---------

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>

* chore: remove CombineProgressEvents type

* chore: fix type errs

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Steve Loeppky <biglep@filoz.org>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: ZenGround0 <5515260+ZenGround0@users.noreply.github.com>
Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>
Co-authored-by: Rod Vagg <rod@vagg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team/filecoin-pin "Filecoin Pin" project is a stakeholder for this work. team/fs-wg FOC working group is a stakeholder for this work, and thus wants to track it on their project board.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants