spec #113 change review #11
Conversation
| 'all': [ | ||
| 'id', | ||
| 'before_cursor', | ||
| 'after_cursor', |
There was a problem hiding this comment.
why is after_cursor query removed from list_merchant_profile endpoint?
| }, | ||
| api_client=api_client | ||
| ) | ||
| self._list_by_payment_instrument_id_endpoint = finix.api_client.Endpoint( |
There was a problem hiding this comment.
verifying a payment instrument endpoint, ie POST a payment instrument verification endpoint is still missing? (ignore where comment is made)
| from finix.model.create_identity_request_entity_dob import CreateIdentityRequestEntityDob | ||
| from finix.model.create_identity_request_entity_incorporation_date import CreateIdentityRequestEntityIncorporationDate | ||
| from finix.model.create_identity_request_entity_personal_address import CreateIdentityRequestEntityPersonalAddress | ||
| globals()['CreateIdentityRequestEntityBusinessAddress'] = CreateIdentityRequestEntityBusinessAddress |
There was a problem hiding this comment.
are those sub-models supposed to get deleted? Corresponding sub-models are used in update_identity_request_entity model, create and update models are inconsistent
There was a problem hiding this comment.
OpenAPI spec updated to: (#113)
Changes
- UPDATE update device endpoint
- UPDATE update_merchant_profile endpoint
- DELETE update_settlement endpoint
- ADD list_verification_by_payment_instrument_id endpoint
- UPDATE fields in multiple models
Problems
- the endpoint to verifying a payment instrument is missing
- Models create_identity_request_entity and update_identity_request_entity are inconsistent, the former is lacking several fields and sub-models
TODO
Update tests for the 4 directly changed API endpoints
Changes of fields in multiple models could break some tests. Make necessary changes to pass the tests.
Checkbox above shows the progress.
As the spec has some problems, may need to update to a new spec
this PR is for reviewing change brought by spec#113, do not approve and merge