Draft
Conversation
AustinBenoit
force-pushed
the
cpp-17-updates
branch
from
312953e to
a3f5bc6
Compare
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's build configuration by upgrading the required C++ standard from C++14 to C++17. This change allows the codebase to leverage newer language features and improvements available in C++17, potentially enhancing code quality, performance, and developer productivity. The update is applied consistently across the main project and all integration test modules. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the C++ standard from 14 to 17 across various CMakeLists.txt files. The changes are straightforward, but several files have outdated comments that still refer to C++14. I've added suggestions to update these comments for consistency and maintainability.
Comment on lines
87
to
+88
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
Contributor
There was a problem hiding this comment.
This comment is outdated. With the C++ standard updated to 17, this should be updated as well for consistency.
# Firebase C++ SDK requires C++17.
set (CMAKE_CXX_STANDARD 17)
Comment on lines
87
to
+88
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
Contributor
There was a problem hiding this comment.
This comment is outdated. With the C++ standard updated to 17, this should be updated as well for consistency.
# Firebase C++ SDK requires C++17.
set (CMAKE_CXX_STANDARD 17)
Comment on lines
18
to
+19
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
Contributor
There was a problem hiding this comment.
This comment is outdated. With the C++ standard updated to 17, this should be updated as well for consistency.
# Firebase C++ SDK requires C++17.
set (CMAKE_CXX_STANDARD 17)
Comment on lines
87
to
+88
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
Contributor
There was a problem hiding this comment.
This comment is outdated. With the C++ standard updated to 17, this should be updated as well for consistency.
# Firebase C++ SDK requires C++17.
set (CMAKE_CXX_STANDARD 17)
Comment on lines
87
to
+88
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
Contributor
There was a problem hiding this comment.
This comment is outdated. With the C++ standard updated to 17, this should be updated as well for consistency.
# Firebase C++ SDK requires C++17.
set (CMAKE_CXX_STANDARD 17)
Comment on lines
87
to
+88
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
Contributor
There was a problem hiding this comment.
This comment is outdated. With the C++ standard updated to 17, this should be updated as well for consistency.
# Firebase C++ SDK requires C++17.
set (CMAKE_CXX_STANDARD 17)
Comment on lines
87
to
+88
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
Contributor
There was a problem hiding this comment.
This comment is outdated. With the C++ standard updated to 17, this should be updated as well for consistency.
# Firebase C++ SDK requires C++17.
set (CMAKE_CXX_STANDARD 17)
Comment on lines
87
to
+88
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
Contributor
There was a problem hiding this comment.
This comment is outdated. With the C++ standard updated to 17, this should be updated as well for consistency.
# Firebase C++ SDK requires C++17.
set (CMAKE_CXX_STANDARD 17)
Comment on lines
87
to
+88
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
Contributor
There was a problem hiding this comment.
This comment is outdated. With the C++ standard updated to 17, this should be updated as well for consistency.
# Firebase C++ SDK requires C++17.
set (CMAKE_CXX_STANDARD 17)
Comment on lines
87
to
+88
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
Contributor
There was a problem hiding this comment.
This comment is outdated. With the C++ standard updated to 17, this should be updated as well for consistency.
# Firebase C++ SDK requires C++17.
set (CMAKE_CXX_STANDARD 17)
a3f5bc6 to
ab54ef1
Compare
AustinBenoit
added
the
tests-requested: full
github-actions
bot
added
tests: in-progress
❌ Integration test FAILEDRequested by @AustinBenoit on commit f24017f
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update to c++ 17
Testing
Currently running all test apps on desktop, iOS and android
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.