Skip to content

fix(installations, web): More explicit interop types #17819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −7
Open

fix(installations, web): More explicit interop types #17819

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bee8c56
fix(installations, web): More explicit interop types
MichaelVerdon Oct 27, 2025
4216790
chore: format-ci
MichaelVerdon Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions ...p_installations/firebase_app_installations_web/lib/src/interop/installations_interop.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,15 @@ external JSPromise /* void */ deleteInstallations(

@JS()
@staticInterop
external JSFunction onIdChange(
InstallationsJsImpl installations, JSFunction forceRefresh);
external JSFunction onIdChange(JSObject installations, JSFunction forceRefresh);

@JS('Installations')
@staticInterop
abstract class InstallationsJsImpl {}

extension InstallationsJsImplExtension on InstallationsJsImpl {
extension type InstallationsJsImplExtension._(JSObject _) implements JSObject {
external AppJsImpl get app;
}

extension type InstallationsJsImpl._(JSObject _) implements JSObject {
external JSPromise<JSString> getId();
external JSPromise<JSString> getToken([JSBoolean? forceRefresh]);
external JSPromise deleteInstallations();
external JSFunction onIdChange(JSFunction forceRefresh);
}
Loading