-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add initial devcontainer configuration #1832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @ifevicke-cmd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a foundational DevContainer setup, allowing developers to quickly spin up a consistent development environment with pre-configured tools and dependencies. This streamlines onboarding for new contributors and ensures everyone is working in the same environment, reducing 'it works on my machine' issues. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a basic devcontainer configuration, which is a positive step towards a consistent development environment. The current configuration is functional, but I've provided a suggestion to make it more robust and developer-friendly by pinning the base image version, adding a container name, and including a customizations block for project-specific VS Code settings and extensions.
| { | ||
| "image": "mcr.microsoft.com/devcontainers/universal:2", | ||
| "features": {} | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good initial devcontainer setup. To make it more robust and improve the developer experience, I suggest a few enhancements:
- Add a
nameproperty: This gives your dev container a recognizable name in the UI. You can replace"My Project"with a more suitable name. - Pin the image version: Using a floating tag like
:2can lead to inconsistencies if the base image is updated. Pinning to a specific version (e.g.,2-jammy) ensures a reproducible environment for all developers. - Add a
customizationsblock: This is a great place to recommend VS Code extensions and settings specific to this project, which can significantly improve the developer experience out of the box.
| { | |
| "image": "mcr.microsoft.com/devcontainers/universal:2", | |
| "features": {} | |
| } | |
| { | |
| "name": "My Project", | |
| "image": "mcr.microsoft.com/devcontainers/universal:2-jammy", | |
| "features": {}, | |
| // Configure properties specific to VS Code. | |
| "customizations": { | |
| "vscode": { | |
| // Add the IDs of extensions you want installed when the container is created. | |
| "extensions": [], | |
| // Set *default* container specific settings.json values on container create. | |
| "settings": {} | |
| } | |
| } | |
| } |
No description provided.