-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add basic devcontainer configuration #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @ifevicke-cmd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a standardized development environment by integrating a basic DevContainer configuration. This will allow developers to quickly set up a consistent workspace with pre-configured tools and dependencies, streamlining the onboarding process and ensuring uniformity across development machines. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a basic devcontainer configuration, which is a great step towards standardizing the development environment. My review includes a suggestion to pin the Docker image version in devcontainer.json. This will ensure a more stable and reproducible environment for all developers by preventing unexpected changes from upstream image updates. Overall, this is a valuable addition.
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "image": "mcr.microsoft.com/devcontainers/universal:2", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better reproducibility of the development environment, it's recommended to pin the container image to a more specific version instead of using a floating tag like :2. This prevents unexpected changes in the environment when the base image is updated. Consider using a tag that includes the OS distribution, for example 2-jammy, or a specific version with a date.
| "image": "mcr.microsoft.com/devcontainers/universal:2", | |
| "image": "mcr.microsoft.com/devcontainers/universal:2-jammy", |
No description provided.