Merged
Conversation
izqui
force-pushed
the
budget-modules
branch
from
b5493e0 to
60f4e3a
Compare
Evalir
reviewed
Sep 29, 2022
Evalir
reviewed
Oct 5, 2022
| error AlreadyExecutedForPeriod(uint256 allowanceId, uint256 paymentId, uint40 nextExecutionTime); | ||
|
|
||
| // Protected so only spenders from the parent allowance to the one recurring payments can spend can add payments | ||
| function addPayment(uint256 allowanceId, address to, uint256 amount) |
Contributor
There was a problem hiding this comment.
I think a function to batch-create payments (like executeMultiPayments for executing multiple payments) would be useful as well.
* UpgradeableModuleProxyFactory: register * FirmBase, UpgradeableModuleProxyFactory: events to enable indexing * UpgradeableModuleProxyFactory: test upgrades and tighten types everywhere * UpgradeableModuleProxyFactory: test registry * UpgradeableModuleProxyFactory: more tests
izqui
changed the title
izqui
changed the title
Evalir
reviewed
Oct 19, 2022
* fix(events): make event naming consistent * chore: revert zodiac-related changes
izqui
changed the title
izqui
changed the title
izqui
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though originally in this branch, RecurringPayments has been moved into a separate PR #86 as this one already has several big things and should be merged ASAP
TODO: