chore(cardano): enable tagged sets in tx serialization#9
Closed
slowbackspace wants to merge 1 commit intodevelopfrom
Closed
chore(cardano): enable tagged sets in tx serialization#9slowbackspace wants to merge 1 commit intodevelopfrom
slowbackspace wants to merge 1 commit intodevelopfrom
Conversation
32b3e22 to
e44b0bb
Compare
e44b0bb to
aa0e06b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the first of two PRs preparing Suite for the upcoming Cardano hard fork. Key updates include:
Transaction Serialization
Post hard fork, all transactions must be serialized using tagged CBOR sets. This feature is already supported by Trezor/Connect (via
tagCborSetsparam intrezorConnect.cardanoSignTransaction) and is now also available in @fivebinaries/coinselection.Staking Rewards Withdrawal
Users withdrawing staking rewards will need to make a governance decision by selecting one of three options:
Changes in This PR
prepareCertificatesto convert from trezor-connect certificate format into coinselection lib formatgetVotingCertificatesfor creating voting cert in trezor connect formatExample usage of
getVotingCertificates:Next Steps
The next PR will focus on introducing a user interface to allow users to select their preferred governance participation option before proceeding with staking reward withdrawals.