This repository was archived by the owner on Jan 15, 2026. It is now read-only.
Update does_table_exist.sql #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update does_table_exist.sql Usage of adapter.get_relation causes a failure when fivetran/shopify package is also used in a project due to quoting of objects in that package. Suggestion is to replace adapter.get_relation with api.Relation.create in this macro. Please see: oracle/dbt-oracle#5 (comment) * Update CHANGELOG.md * Update dbt_project.yml
fivetran-catfritz
changed the title
| @@ -1,17 +1,14 @@ | |||
| {%- macro does_table_exist(table_name) -%} | |||
| {%- if execute -%} -- returns true when dbt is in execute mode | |||
| {%- set ns = namespace(has_table=false) -%} -- declare boolean namespace and default value | |||
Contributor
Author
There was a problem hiding this comment.
ns is never used--removed.
Comment on lines
-4
to
-11
| {%- for node in graph.sources.values() -%} -- grab sources from the dictionary of nodes | ||
| -- call the database for the matching table | ||
| {%- set source_relation = adapter.get_relation( | ||
| database=node.database, | ||
| schema=node.schema, | ||
| identifier=node.identifier ) -%} | ||
| {%- if source_relation == None and node.name | lower == table_name | lower -%} | ||
| {{ return(False) }} -- return false if relation identified by the database.schema.identifier does not exist for the given table name |
Contributor
Author
There was a problem hiding this comment.
Based on alignment meeting, we'll directly use the values for adapter.get_relation since we have them, which is similar to what is used in Lever.
Comment on lines
7
to
15
| {# DEBUG #} | ||
| {% if execute %} | ||
| {{print('-------- FOR DEBUGGING --------')}} | ||
| {{print('The value of stripe_source.does_table_exist(price) is: ' ~ stripe_source.does_table_exist('price'))}} | ||
| {{print('The value of stripe_source.does_table_exist(plan) is: ' ~ stripe_source.does_table_exist('plan'))}} | ||
| {{print('what is passed to union macro is: '~ price_or_plan)}} | ||
| {{print('--------')}} | ||
| {% endif %} | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Will remove before merge.
7 tasks
fivetran-reneeli
approved these changes
Apr 1, 2025
Contributor
fivetran-reneeli
left a comment
fivetran-reneeli
left a comment
There was a problem hiding this comment.
Looks good, just one minor suggestion!
Comment on lines
7
to
15
| {# DEBUG #} | ||
| {% if execute %} | ||
| {{print('-------- FOR DEBUGGING --------')}} | ||
| {{print('The value of stripe_source.does_table_exist(price) is: ' ~ stripe_source.does_table_exist('price'))}} | ||
| {{print('The value of stripe_source.does_table_exist(plan) is: ' ~ stripe_source.does_table_exist('plan'))}} | ||
| {{print('what is passed to union macro is: '~ price_or_plan)}} | ||
| {{print('--------')}} | ||
| {% endif %} | ||
|
|
Co-authored-by: Renee Li <91097070+fivetran-reneeli@users.noreply.github.com>
fivetran-avinash
approved these changes
Apr 2, 2025
fivetran-avinash
left a comment
fivetran-avinash
left a comment
There was a problem hiding this comment.
Good to go! One request to update the LICENSE.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
Submission Checklist
Submitter:
Changelog
Validation
Recreate error from the Shopify example:
Issue is resolved with updates:
Consistency tests pass
Test
planvspriceswitch.planis now correctly selected whenpricedoes not exist and theusing_*var is not set.