Skip to content
This repository was archived by the owner on Jan 15, 2026. It is now read-only.

Conversation

@fivetran-joemarkiewicz
Copy link
Contributor

PR Overview

Package version introduced in this PR: v0.15.1

This PR addresses the following Issue/Feature(s): dbt_stripe Issue #94

Summary of changes:

  • Removes trailing spaces in yml documentation.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
      • Confirmed changes work locally.
    • Testing Instructions: Confirm the change addresses the issue(s)
      • Confirm changes work locally .
    • Focus Areas: Complex logic or queries that need extra attention
      • Make sure all trailing spaces are removed in yml documentation.

Changelog

  • Draft changelog for PR
  • Final changelog for release review

* Q2 FY26: Apply automated update.

* Q2 FY26: Update auto-release workflow only.

---------

Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review July 28, 2025 19:15
Copy link

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-joemarkiewicz Approved with a few notes (I don't think these are blocking)

  • bash .buildkite/scripts/run_models.sh postgres in .buildkite/pipeline.yml has a trailing space that you fixed in dbt_stripe, do we want to make the same change here?
  • Ditto the bug-report.yml on line 41.

A few things I noticed you could potentially fix in the yml (if time permits, if not I can create an issue):

  1. In stg_stripe__subscription, customer_id is listed twice.
  2. shipping_tracking_number and source_id descriptions in stg_stripe__charge are truncated. You can copy paste over the src yml description.
  3. customer is misspelled in the phone description on line 244 in the stg_stripe.yml.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the docs:ready Triggers the docs generator workflow. label Jul 29, 2025
@fivetran-joemarkiewicz fivetran-joemarkiewicz added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Jul 29, 2025
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit adc4177 into main Jul 30, 2025
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants