-
Notifications
You must be signed in to change notification settings - Fork 30
example(refiner): added new connector for refiner connector #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🧹 Python Code Quality Check✅ No issues found in Python Files. This comment is auto-updated with every commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new Refiner Survey Analytics Connector that integrates with the Refiner API to sync NPS survey data, responses, and user information into Fivetran destinations. The connector implements incremental syncs with cursor-based pagination, proper error handling, and comprehensive state management.
Key changes:
- New connector implementation with 5 normalized tables (surveys, questions, responses, answers, respondents)
- Incremental sync support based on
last_data_reception_attimestamps with configurable start dates - Comprehensive error handling with exponential backoff and proper retry logic for transient failures
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| connectors/refiner/connector.py | Main connector implementation with API integration, pagination, state management, and data transformation logic |
| connectors/refiner/configuration.json | Configuration template with API key and optional start date parameters |
| connectors/refiner/README.md | Complete documentation covering setup, features, authentication, data handling, and table schemas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
connectors/refiner/connector.py:28
- Import of 'urlencode' is not used.
from urllib.parse import urlencode
fivetran-chinmayichandrasekar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-sushmitha Left a few suggestions. Thanks.
Also, the main Readme.md file is missing.
fivetran-sahilkhirwal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address these comments as well as copilot comments :)
|
Please link the example to the main README |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 17 comments.
fivetran-chinmayichandrasekar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please address the review comments from Copilot.
fivetran-chinmayichandrasekar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left a suggestion and a comment. Please check. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
fivetran-sahilkhirwal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
fivetran-rishabhghosh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wait till tech writer approves it
fivetran-chinmayichandrasekar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of suggestions again. Thanks.
Co-authored-by: fivetran-chinmayichandrasekar <chinmayi.chandrasekar@fivetran.com>
a9ae0c2
Co-authored-by: fivetran-chinmayichandrasekar <chinmayi.chandrasekar@fivetran.com>
fivetran-chinmayichandrasekar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions. Thanks
fivetran-chinmayichandrasekar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions. Thanks.
Co-authored-by: fivetran-chinmayichandrasekar <chinmayi.chandrasekar@fivetran.com>
Co-authored-by: fivetran-chinmayichandrasekar <chinmayi.chandrasekar@fivetran.com>
Co-authored-by: fivetran-chinmayichandrasekar <chinmayi.chandrasekar@fivetran.com>
Co-authored-by: fivetran-chinmayichandrasekar <chinmayi.chandrasekar@fivetran.com>
Co-authored-by: fivetran-chinmayichandrasekar <chinmayi.chandrasekar@fivetran.com>
Co-authored-by: fivetran-chinmayichandrasekar <chinmayi.chandrasekar@fivetran.com>
Co-authored-by: fivetran-chinmayichandrasekar <chinmayi.chandrasekar@fivetran.com>
Co-authored-by: fivetran-chinmayichandrasekar <chinmayi.chandrasekar@fivetran.com>
fivetran-chinmayichandrasekar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fivetran-chinmayichandrasekar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fivetran-chinmayichandrasekar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jira ticket
Closes
<ADD TICKET LINK HERE, EACH PR MUST BE LINKED TO A JIRA TICKET>Description of Change
Business value and revenue impact
This Refiner connector directly helps Fivetran customers unlock survey analytics at scale:
Customer feedback analytics
User-level insights
Operational efficiency
Testing
<MENTION ABOUT YOUR TESTING DETAILS HERE, ATTACH SCREENSHOTS IF NEEDED (WITHOUT PII)>Checklist
Some tips and links to help validate your PR:
fivetran debugcommand.