Expose Ingestion API with Inversion of Control #191
+873
−251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-j97
requested changes
Nov 8, 2025
marvin-j97
reviewed
Nov 8, 2025
marvin-j97
reviewed
Nov 8, 2025
marvin-j97
reviewed
Nov 9, 2025
zaidoon1
force-pushed
the
zaidoon/ingestion-api-inversion-control
branch
3 times, most recently
from
a043736 to
14ef584
Compare
Contributor
|
I'm currently massively simplifying the flush logic such that is gets really easy to flush active and sealed memtables in one go by just calling |
marvin-j97
reviewed
Nov 11, 2025
Contributor
|
(Forgot to submit comments) But as I said, I am currently changing the Flush API which should make the ingestion API much simpler. (WIP at #194) |
marvin-j97
reviewed
Nov 11, 2025
zaidoon1
force-pushed
the
zaidoon/ingestion-api-inversion-control
branch
3 times, most recently
from
1af202a to
87c7d03
Compare
zaidoon1
force-pushed
the
zaidoon/ingestion-api-inversion-control
branch
from
87c7d03 to
36b2651
Compare
marvin-j97
reviewed
Nov 15, 2025
Comment on lines
193
to
194
| false, | ||
| false, |
Contributor
There was a problem hiding this comment.
I forgot to document this - but I purposefully avoided using the config for pinning because when you ingest a very large database it is assigned to L1 and will pin all those blocks which could provoke OOM.
marvin-j97
reviewed
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #190