fixed cafe bug #26
Open
fixed cafe bug #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maedana
reviewed
Sep 4, 2023
cafe.rb
Outdated
| @@ -1,4 +1,5 @@ | |||
| # frozen_string_literal: true | |||
| # require 'debug' | |||
maedana
reviewed
Sep 4, 2023
cafe.rb
Outdated
| ].freeze | ||
|
|
||
| def take_order(menus) | ||
| # binding.break |
maedana
reviewed
Sep 4, 2023
cafe.rb
Outdated
| order2 = take_order(FOODS) | ||
|
|
||
| total = FOODS[order1][:price] + DRINKS[order2][:price] | ||
| total = FOODS[order2][:price].to_i + DRINKS[order1][:price].to_i |
There was a problem hiding this comment.
これでOKです。しかし本質的にはorder1,2のようなわかりにくい命名が引き起こしがちな不具合ともいえます。したがってよりよい解答としては変数名の見直しまでするといいですね。修正は任意で結構です。
Author
There was a problem hiding this comment.
修正しました！今のコードはorder１はdrinkorderになって、食べ物の分はfoodorderになりました。
maedana
reviewed
Sep 6, 2023
|
|
||
| puts 'bugカフェへようこそ！ご注文は？ 番号でどうぞ' | ||
| order1 = take_order(DRINKS) | ||
| drinkorder = take_order(DRINKS) |
There was a problem hiding this comment.
細かいことをいうとスネークケースで書いたほうがいいのでdrink_orderが適切ですね
maedana
reviewed
Sep 6, 2023
|
|
||
| puts 'フードメニューはいかがですか?' | ||
| order2 = take_order(FOODS) | ||
| foodorder = take_order(FOODS) |
maedana
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.