cleanup code and comments before 2025 OZ audit #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruteri
reviewed
Jul 31, 2025
src/FlashtestationRegistry.sol
Outdated
| * @dev This function exists so that the TEE does not need to be funded with gas for transaction fees, and | ||
| * instead can rely on any EOA to execute the transaction, but still only allow quotes from attested TEEs | ||
| * @dev Replay is implicitly shielded against through the transaction's nonce (TEE must sign the new nonce) | ||
| * @dev Replay is implicitly shielded against replay attacksthrough the transaction's nonce (TEE must sign the new nonce) |
Ruteri
approved these changes
Jul 31, 2025
Melvillian
force-pushed
the
final-cleanup-before-2025-audit
branch
from
5fc2ee2 to
8d2747b
Compare
Before we give a commit hash to audit to our auditor, we want to make sure the code is in the final state we want it to be in, both to make the auditors' lives easier, and to make sure the code is production ready
Melvillian
force-pushed
the
final-cleanup-before-2025-audit
branch
from
8d2747b to
47b5544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we give a commit hash to audit to our auditor, we want to make sure the code is in the final state we want it to be in, both to make the auditors' lives easier, and to make sure the code is production ready