N-12 use ReentrancyGuardTransientUpgradeable for reentrancy guard #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the N-12 of the Q3 2025 OZ audit The ReentrancyGuardTransientUpgradeable module should be used instead of ReentrancyGuardTransient, as it ensures that all modules remain upgradeable. Although both versions function identically, transitioning to the upgradeable version aligns with best practices for upgradeable contract architectures. Consider using the ReentrancyGuardTransientUpgradeable module instead of the ReentrancyGuardTransient module and ensuring that all inherited upgradeable module initializers are called within the initialize function, such as __UUPSUpgradeable_init() for UUPS support and __ReentrancyGuardTransient_init() for the reentrancy guard. Doing so will help improve the maintainability and upgradeability of the contract.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the N-12 of the Q3 2025 OZ audit
The ReentrancyGuardTransientUpgradeable module should be used instead of ReentrancyGuardTransient, as it ensures that all modules remain upgradeable. Although both versions function identically, transitioning to the upgradeable version aligns with best practices for upgradeable contract architectures.
Consider using the ReentrancyGuardTransientUpgradeable module instead of the ReentrancyGuardTransient module and ensuring that all inherited upgradeable module initializers are called within the initialize function, such as __UUPSUpgradeable_init() for UUPS support and __ReentrancyGuardTransient_init() for the reentrancy guard. Doing so will help improve the maintainability and upgradeability of the contract.