Skip to content

readyz/livez cleanup #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
metachris merged 1 commit into from
Sep 4, 2025
Merged

readyz/livez cleanup #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions httpserver/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,24 @@ func (srv *Server) handleAPI(w http.ResponseWriter, r *http.Request) {

func (srv *Server) handleLivenessCheck(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(http.StatusOK)
w.Write([]byte("OK")) //nolint:errcheck
}

func (srv *Server) handleReadinessCheck(w http.ResponseWriter, r *http.Request) {
if !srv.isReady.Load() {
w.WriteHeader(http.StatusServiceUnavailable)
w.Write([]byte("not ready")) //nolint:errcheck
return
}

w.WriteHeader(http.StatusOK)
w.Write([]byte("OK")) //nolint:errcheck
}

func (srv *Server) handleDrain(w http.ResponseWriter, r *http.Request) {
if wasReady := srv.isReady.Swap(false); !wasReady {
return
}
// l := logutils.ZapFromRequest(r)
srv.log.Info("Server marked as not ready")
time.Sleep(srv.cfg.DrainDuration) // Give LB enough time to detect us not ready
}
Expand All @@ -35,6 +37,5 @@ func (srv *Server) handleUndrain(w http.ResponseWriter, r *http.Request) {
if wasReady := srv.isReady.Swap(true); wasReady {
return
}
// l := logutils.ZapFromRequest(r)
srv.log.Info("Server marked as ready")
}
Loading