Skip to content

Conversation

@dvush
Copy link
Contributor

@dvush dvush commented Sep 26, 2025

  1. parse UUID in bundles to return errors to users early
    • note: we modify semantics of unique key but its not a problem since this is only used internally to distinguish bundles in memory
  2. add delayedRefund field

@dvush dvush requested a review from metachris September 26, 2025 11:20
RefundPercent *uint64 `json:"refundPercent,omitempty"`
RefundRecipient *common.Address `json:"refundRecipient,omitempty"`
RefundTxHashes []string `json:"refundTxHashes,omitempty"`
// if set to true refund will be paid out of block
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe move comment to right of code like some of the above fields, which would also make the lines align 🙏

@dvush dvush merged commit 2b3d24e into main Sep 26, 2025
2 checks passed
@dvush dvush deleted the delayed_refunds branch September 26, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants