tests: Allow screenshot ref commit test to run offline #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbhtt
force-pushed
the
bbhtt/test-ref-offline
branch
from
92dd97e to
3c38c07
Compare
We disable appstream-compose and instead add some bogus data to the media dir and pass --mirror-screenshot-url so that flatpak-builder commits the screenshot ref. Since appstream-compose is disabled mirror-screenshot-url arg has no effect other than allowing us to commit the bogus screenshot ref. Desktop, metainfo and icon files are also dropped from manifest since they have no use without appstream compose. This is needed to run the test offline as appstream tries to download the screenshots online.
bbhtt
force-pushed
the
bbhtt/test-ref-offline
branch
from
3c38c07 to
959ab1e
Compare
Contributor
Author
|
Any feedback on this? We probably should include this in the next release. |
Contributor
|
Looks fine to me. Making things work without invoking the network is always good IMO. |
Contributor
Author
|
OK let's go with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it harder for me to write the test for #652, but if offline tests are wanted, so be it.
I didn't delete the test files, as I plan to reuse them later for the test in #652. I need some fully qualified and valid desktop file, metainfo file for that.