-
Couldn't load subscription status.
- Fork 585
feat: Fullscreen support on Mobile & Web #5751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…nt interface imports
This reverts commit e061ab1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds fullscreen support for mobile and web platforms to complement the existing desktop-only window.full_screen capability. The implementation adds a new cross-platform Page.full_screen property that works across mobile, desktop, and web environments.
Key Changes:
- Added a new
full_screenproperty to the PythonPageclass that works across all platforms - Implemented platform-specific fullscreen handlers (web uses Fullscreen API, mobile uses SystemUIMode, desktop uses existing window API)
- Refactored Dart utility files to consolidate web/IO interfaces for better code organization
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/python/packages/flet/src/flet/controls/page.py | Adds cross-platform full_screen property with getter/setter to Page class |
| sdk/python/packages/flet/docs/controls/page.md | Documents the new fullscreen toggle feature with usage notes |
| sdk/python/examples/controls/page/fullscreen.py | Provides example implementation of fullscreen toggle functionality |
| packages/flet/lib/src/utils/web_interface.dart | Creates web-specific interface with fullscreen implementation using Fullscreen API |
| packages/flet/lib/src/utils/user_fonts_web.dart | Removes font-only utilities (consolidated into web_interface.dart) |
| packages/flet/lib/src/utils/user_fonts.dart | Updates import to use new consolidated interface files |
| packages/flet/lib/src/utils/io_interface.dart | Adds fullscreen delegation to desktop implementation |
| packages/flet/lib/src/controls/page.dart | Implements platform-specific fullscreen handling in page control |
| client/lib/main.dart | Refactors platform check to use utility function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine
Deploying flet-docs with
|
| Latest commit: |
808d1e1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4042584b.flet-docs.pages.dev |
| Branch Preview URL: | https://fullscreen.flet-docs.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…s, refactor `parseTextInputType`
Fix #4551
Example
Summary by Sourcery
Enable cross-platform fullscreen support by adding Page.full_screen to the Python SDK and set_fullscreen handling in the Dart layer, backed by new IO and web interfaces, and update documentation with usage examples.
New Features:
Enhancements:
Documentation:
Summary by Sourcery
Enable cross-platform fullscreen support by adding a new Page.full_screen property in the Python SDK and implementing platform-specific fullscreen logic in the Dart layer, backed by unified IO and web interfaces, and update documentation with usage examples.
New Features:
Enhancements:
Documentation:
Chores: