[FXC-3564][FXC-979] ForceOutput and its stopping criterion #1519
+2,111
−322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angranl-flex
force-pushed
the
angran/forceOutput
branch
from
c87d8f8 to
a611fc9
Compare
angranl-flex
force-pushed
the
angran/forceOutput
branch
4 times, most recently
from
0c3f55f to
48ac55a
Compare
angranl-flex
force-pushed
the
angran/forceOutput
branch
from
bf011b3 to
0a9b5ea
Compare
| ] | ||
|
|
||
| ForceOutputCoefficientNames = Literal[ | ||
| "CD", |
Collaborator
There was a problem hiding this comment.
Can we somehow unify this with the ones in results_utils.py?
angranl-flex
force-pushed
the
angran/forceOutput
branch
from
5dc97e5 to
a78def5
Compare
| description="List of force coefficients. Including CL, CD, CFx, CFy, CFz, CMx, CMy, CMz. " | ||
| "For surface forces, their SkinFriction/Pressure is also supported, such as CLSkinFriction and CLPressure." | ||
| ) | ||
| models: List[Union[ForceOutputModelType, str]] = pd.Field( |
Collaborator
There was a problem hiding this comment.
Can we try removing these string in schemas? The ID string should not be able to reach here.
| description="List of surface/volume models whose force contribution will be calculated.", | ||
| ) | ||
| moving_statistic: Optional[MovingStatistic] = pd.Field( | ||
| None, description="The moving statistics used to monitor the output." |
Collaborator
There was a problem hiding this comment.
Can we change the description here? (and other moving_statistic)
Suggested change
| None, description="The moving statistics used to monitor the output." | |
| None, description="When specified, report moving statistics of the fields instead." |
| return value | ||
| model_ids = [] | ||
| for model in value: | ||
| if isinstance(model, get_args(get_args(ForceOutputModelType)[0])): |
Collaborator
There was a problem hiding this comment.
do we need the isinstance check here?
Also can we wrap this and share with other places that serializes to id instead of models?
angranl-flex
force-pushed
the
angran/forceOutput
branch
from
b993e71 to
b729e5b
Compare
…t coefficient csv file
… will trigger external postprocessing.
…re expanded before validation
angranl-flex
force-pushed
the
angran/forceOutput
branch
from
b729e5b to
54a98c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.