Fix to PhotoThermalWaveguides notebook for some numpy versions #423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice example btw! :)
One of the checks was erroring for me, which is what this PR fixes (maybe numpy v2 vs. v1 issue? not sure at which point this has become a hard error).
More generally, was this AI generated?
AI likes to do all these defensive checks. Normally, we don't really do this in our notebooks, and it would be quite verbose to do so everywhere. I feel like it can just be removed?
Regarding the isotropic permittivity check though (which is what I'm fixing), I feel like there's even a potential issue: why do we need the permittivity to be isotropic? Note that it won't be at geometry interfaces due to subpixel, which I assume is not a problem here if the recorded data does not cover the waveguide interface? But in general why enforce this at all as opposed to compute absorption components from each of the field/permittivity components separately, and add them up?