Skip to content

Update dtgen to add docstring support#1581

Merged
lockshaw merged 1 commit intoflexflow:masterfrom
lockshaw:dtgen-docstring
Jan 20, 2025
Merged

Update dtgen to add docstring support#1581
lockshaw merged 1 commit intoflexflow:masterfrom
lockshaw:dtgen-docstring

Conversation

@lockshaw
Copy link
Collaborator

@lockshaw lockshaw commented Jan 20, 2025

Description of changes:

dtgen now supports specifying Doxygen docstrings in .struct.toml (top-level docstring example, field docstring example), .enum.toml (top-level docstring example, value docstring example), and .variant.toml (top-level docstring example, value docstring example) files.

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

  • Closes #

Before merging:

  • Did you update the flexflow-third-party repo, if modifying any of the Cmake files, the build configs, or the submodules?

This change is Reviewable

@lockshaw lockshaw requested a review from Marsella8 January 20, 2025 02:44
@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (d4a92da) to head (3a29c9e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1581   +/-   ##
=======================================
  Coverage   60.47%   60.47%           
=======================================
  Files         606      606           
  Lines       14723    14723           
=======================================
  Hits         8903     8903           
  Misses       5820     5820           
Flag Coverage Δ
unittests 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@lockshaw lockshaw merged commit 0bde2da into flexflow:master Jan 20, 2025
9 of 10 checks passed
@lockshaw lockshaw deleted the dtgen-docstring branch January 20, 2025 03:53
@lockshaw lockshaw mentioned this pull request Jan 21, 2025
@victorli2002 victorli2002 mentioned this pull request Mar 12, 2025
@victorli2002 victorli2002 mentioned this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant