Implement MCMC mapping/optimization algorithm#1619
Implement MCMC mapping/optimization algorithm#1619lockshaw merged 10 commits intoflexflow:masterfrom
Conversation
| @@ -0,0 +1,197 @@ | |||
| #include "compiler/machine_mapping/apply_substitution_and_update_machine_mapping.h" | |||
There was a problem hiding this comment.
somehow break this up and remove some dup with the base apply_substitution
try to add tests
| if (allowed_machine_views.empty()) { | ||
| return std::nullopt; | ||
| } | ||
| machine_views.insert({layer, *(allowed_machine_views.begin())}); |
There was a problem hiding this comment.
get_first or something in containers / util or write one
|
in general, try to use transforms / maps / optional.h / stuff in containers instead of the big for loops |
lib/compiler/include/compiler/machine_mapping/machine_mapping_mutation_set.h
Show resolved
Hide resolved
lib/compiler/include/compiler/machine_mapping/machine_mapping_mutation_set.h
Outdated
Show resolved
Hide resolved
…into moving it to the other file, also put the evaluate_substitution_ouput outside of apply_substitution since it has a side effect, thinking of making the non-eval-sub version the default
lockshaw
changed the title
lockshaw
left a comment
lockshaw
left a comment
There was a problem hiding this comment.
@lockshaw partially reviewed 32 files and all commit messages, made 6 comments, and resolved 14 discussions.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on victorli2002).
lib/compiler/include/compiler/machine_mapping/machine_mapping_mutation_set.h line 9 at r2 (raw file):
namespace FlexFlow { std::optional<MachineMapping> get_random_mapping(ParallelComputationGraph &pcg,
Suggestion:
ParallelComputationGraph const &pcg,lib/compiler/include/compiler/machine_mapping/machine_mapping_mutation_set.h line 14 at r2 (raw file):
std::optional<MachineMapping> get_random_mutation(SearchResult mapped_pcg,
Suggestion:
SearchResult const &mapped_pcg,lib/compiler/src/compiler/machine_mapping/machine_mapping_mutation_set.cc line 13 at r2 (raw file):
std::optional<MachineMapping> get_random_mapping(ParallelComputationGraph &pcg,
Suggestion:
ParallelComputationGraph const &pcg,lib/compiler/src/compiler/machine_mapping/machine_mapping_mutation_set.cc line 32 at r2 (raw file):
std::optional<MachineMapping> get_random_mutation(SearchResult mapped_pcg,
Suggestion:
get_random_mutation(SearchResult const &mapped_pcg,lib/compiler/src/compiler/mcmc/mcmc_over_mapped_pcg.cc line 18 at r2 (raw file):
SearchResult mcmc_over_mapped_pcg(ParallelComputationGraph &pcg,
Suggestion:
mcmc_over_mapped_pcg(ParallelComputationGraph const &pcg,lib/substitutions/src/substitutions/apply_substitution/apply_substitution.cc line 35 at r2 (raw file):
SubParallelComputationGraph apply_substitution_from_output_result( std::pair<SubParallelComputationGraph, OutputExprToResultSubPCGMapping> substitution_output_result,
Suggestion:
std::pair<SubParallelComputationGraph, OutputExprToResultSubPCGMapping> const &
substitution_output_result,
3 participants
Description of changes:
Related Issues:
Linked Issues:
Issues closed by this PR:
This change is