feat: add completedAt and canceledAt to CLI lean types#132
Merged
Conversation
Add completed_at and canceled_at fields to IssueSummary, SearchSummary, and IssueDetail so the CLI actually requests these timestamps from the API. Enables filtering/sorting by completion date in JSON output and answering questions like "what issues did I close this week?". Closes #131
Add the fields to IssueRow with #[tabled(skip)] so they serialize in JSON but stay hidden from the human table. Populate them in the From impls for IssueSummary and SearchSummary.
flipbit03
force-pushed
the
feat/131-feat-add-completedat-and-canceledat-to-c
branch
from
b0899a0 to
5d9e1f6
Compare
Switch online tests from `cargo test` to `cargo nextest run --fail-fast` so the suite aborts on the first failure instead of running all remaining tests. Applies to Makefile and both CI workflows.
The test workspace is a dedicated free-plan Linear account with hard resource limits (e.g. max 1 team). Zombie resources from crashed runs block subsequent test runs entirely. - Broaden cleanup to delete all resources unconditionally (except the default workspace team, which can't be deleted on free plans) - Add `cleanup-test-workspace` binary to lineark-test-utils - Run it as pre-step and always-run post-step in both CI workflows - Run it before tests in `make test-online`
flipbit03
force-pushed
the
feat/131-feat-add-completedat-and-canceledat-to-c
branch
from
beaf299 to
8d6d121
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
completed_atandcanceled_atfields toIssueSummary,SearchSummary, andIssueDetaillean types so the CLI requests these timestamps from the Linear APICloses #131
Test plan
make checkpasses (lint + doc + build)make testpasses (offline tests)make test-online— verifycompletedAt/canceledAtappear in JSON output for completed/canceled issues viaissues list --format jsonandissues read --format json