Batch orders, GTC/GTD/FOK/FAK order types, typed responses, proxy-wallet support, per-page pagination#14
Merged
floor-licker merged 6 commits intofloor-licker:mainfrom Feb 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for batching order submissions and introduces the FAK order type while keeping existing default (GTC) flows intact.
Changes:
- Added
FAKtoOrderTypeand validated its serde/string representation via a unit test. - Implemented
post_ordersfor submitting up to 15 signed orders in a single/ordersrequest. - Added convenience helpers to create+post single and multiple orders with an explicit
OrderType, preserving existing GTC defaults.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/types.rs |
Extends OrderType with FAK and adds serde/as_str test coverage. |
src/client.rs |
Adds batch posting API and new create+post helper methods; expands tests for batch posting and FAK support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
onsails
changed the title
- Add sig_type/funder params to with_l2_headers() for proxy wallet order signing - Add get_trades_page() and get_orders_page() for per-page cursor pagination - Refactor get_trades/get_orders to use page methods internally
TradeMessage was severely under-specified compared to the Polymarket WS API. Add missing fields needed by the engine: taker_order_id, maker_orders, trader_side, fee_rate_bps, outcome, owner, trade_owner, transaction_hash. Replace untyped status/msg_type strings with proper TradeMessageStatus and TradeMessageType enums.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.