rtd container uses wait-for-it, ensuring postfix before starting supe…#7
Open
rboyd wants to merge 1 commit intofloross:masterfrom
Open
rtd container uses wait-for-it, ensuring postfix before starting supe…#7rboyd wants to merge 1 commit intofloross:masterfrom
rboyd wants to merge 1 commit intofloross:masterfrom
Conversation
Owner
|
I cannot test this pull request right now (in a few days probably). Is someone can test it before i merged it ? Or we will wait until I can. |
Collaborator
|
@rboyd, thanks for the pull! |
Jmennius
requested changes
Sep 24, 2018
Collaborator
Jmennius
left a comment
There was a problem hiding this comment.
I have several points to consider:
- Database is not the only service to wait for - we should also wait for ES and Redis.
- Having the wait-for in compose, always enabled for DB. We should wait for DB conditionally (
RTD_HAS_DATABASE) and do this inrtd-provision.shscript. That way we will cover every use-case. wait-for-it.sh- instead of copying it to the repo (w/o any mention on where it comes from, revision, etc), we should download it in Dockerfile. That will significantly ease maintenance.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rvisord. fixes #5.