Skip to content

rtd container uses wait-for-it, ensuring postfix before starting supe…#7

Open
rboyd wants to merge 1 commit intofloross:masterfrom
rboyd:master
Open

rtd container uses wait-for-it, ensuring postfix before starting supe…#7
rboyd wants to merge 1 commit intofloross:masterfrom
rboyd:master

Conversation

@rboyd
Copy link

@rboyd rboyd commented Sep 9, 2018

…rvisord. fixes #5.

@floross
Copy link
Owner

floross commented Sep 10, 2018

I cannot test this pull request right now (in a few days probably). Is someone can test it before i merged it ? Or we will wait until I can.

@Jmennius
Copy link
Collaborator

@rboyd, thanks for the pull!
I'll review and test in a week or two (on vacation).

Copy link
Collaborator

@Jmennius Jmennius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have several points to consider:

  1. Database is not the only service to wait for - we should also wait for ES and Redis.
  2. Having the wait-for in compose, always enabled for DB. We should wait for DB conditionally (RTD_HAS_DATABASE) and do this in rtd-provision.sh script. That way we will cover every use-case.
  3. wait-for-it.sh - instead of copying it to the repo (w/o any mention on where it comes from, revision, etc), we should download it in Dockerfile. That will significantly ease maintenance.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Database Starting too slowly?

3 participants