Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Oct 31, 2025

Resolves: #1940 (comment)

Change Log


Added

Fixed

  • Incorrect library test group names

Changed

Removed

Deprecated

Security

@norberttech
Copy link
Member

could you add phpunit.xml.dist to tests workflow trigger paths?

@stloyd
Copy link
Member Author

stloyd commented Oct 31, 2025

@norberttech to pass first, it will require: #1945 to be merged

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.54%. Comparing base (24fca74) to head (dfb6fa1).
⚠️ Report is 3 commits behind head on 1.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1944      +/-   ##
==========================================
+ Coverage   77.10%   79.54%   +2.44%     
==========================================
  Files         831      831              
  Lines       24689    24690       +1     
==========================================
+ Hits        19036    19640     +604     
+ Misses       5653     5050     -603     
Components Coverage Δ
etl 88.82% <ø> (ø)
cli 85.96% <ø> (ø)
lib-array-dot 95.00% <ø> (ø)
lib-azure-sdk 60.39% <ø> (ø)
lib-doctrine-dbal-bulk 95.14% <ø> (ø)
lib-filesystem 80.08% <ø> (ø)
lib-types 87.98% <28.57%> (+36.07%) ⬆️
lib-parquet 68.34% <ø> (ø)
lib-parquet-viewer 83.04% <ø> (ø)
lib-snappy 90.18% <ø> (ø)
bridge-filesystem-async-aws 90.16% <ø> (ø)
bridge-filesystem-azure 89.47% <ø> (ø)
bridge-monolog-http 96.91% <ø> (ø)
bridge-openapi-specification 94.50% <ø> (ø)
symfony-http-foundation 73.17% <ø> (ø)
adapter-chartjs 86.36% <ø> (ø)
adapter-csv 88.46% <ø> (ø)
adapter-doctrine 90.97% <ø> (ø)
adapter-elasticsearch 97.17% <ø> (ø)
adapter-google-sheet 91.40% <ø> (ø)
adapter-http 60.56% <ø> (ø)
adapter-json 87.74% <ø> (ø)
adapter-logger 83.33% <ø> (ø)
adapter-meilisearch 97.87% <ø> (ø)
adapter-parquet 78.15% <ø> (ø)
adapter-text 82.92% <ø> (ø)
adapter-xml 82.50% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Due to internal dom differences
@norberttech
Copy link
Member

Probably the easiest way to reproduce all those tests locally is through nix:

nix-shell --arg php-version 8.2 --run "composer test:lib:types"
nix-shell --arg php-version 8.3 --run "composer test:lib:types"
nix-shell --arg php-version 8.4 --run "composer test:lib:types"

(first run will take longer)

@norberttech norberttech merged commit 91acbdf into flow-php:1.x Oct 31, 2025
16 of 17 checks passed
@norberttech norberttech mentioned this pull request Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants