cmetrics: add cmt_expire for expiring metrics.#246
Open
Conversation
…assed expiration timestamp. Signed-off-by: Phillip Whelan <pwhelan@exis.cl>
Signed-off-by: Phillip Whelan <pwhelan@exis.cl>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Phillip Whelan <pwhelan@exis.cl>
…rams. Signed-off-by: Phillip Whelan <pwhelan@exis.cl>
Contributor
Author
|
With a long running test running under valgrind: |
Contributor
Author
Contributor
Author
|
I also monitored the CPU usage: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add two new functions,
cmt_map_metrics_expirefor expiring metrics in acmt_mapandcmt_expirewhich uses the function to expire all the metrics inside acmetricscontext.This function is useful in general for removing metrics with labels for objects that will disappear, ie: PIDs, etc...
This will also be used in fluent/fluent-bit#7615.