Skip to content

plugin_proxy: allow metrics type for output plugin proxy #9735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gracewehner wants to merge 1 commit into
base: master
Choose a base branch
from
Open

plugin_proxy: allow metrics type for output plugin proxy #9735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/flb_plugin_proxy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,7 @@ static int flb_proxy_register_output(struct flb_plugin_proxy *proxy,

/* Plugin registration */
out->type = FLB_OUTPUT_PLUGIN_PROXY;
out->event_type = FLB_OUTPUT_LOGS | FLB_OUTPUT_METRICS;
Comment on lines 364 to +366
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid routing metrics to log-only proxy outputs

By unconditionally setting out->event_type to FLB_OUTPUT_LOGS | FLB_OUTPUT_METRICS for all proxy outputs, any proxy output configured for logs will now also accept metrics when a metrics input matches the same output. Because the proxy definition has no way to declare supported event types, log-only proxy plugins (e.g., Go outputs that only implement log decoding) will start receiving metrics chunks they cannot parse, leading to dropped data or flush errors when metrics inputs are present alongside log inputs. This is a behavioral regression for existing deployments that used proxy outputs for logs only and now have metrics enabled; consider making the event type configurable or derived from the proxy/plugin registration instead of forcing metrics support for every proxy output.

Useful? React with 👍 / 👎.

out->proxy = proxy;
out->flags = def->flags;
out->name = flb_strdup(def->name);
Expand Down
Loading