feat(fluent-bit): support yaml config#618
feat(fluent-bit): support yaml config#618drinkingjasminegreentea wants to merge 3 commits intofluent:mainfrom
Conversation
Signed-off-by: Raihan <36995715+drinkingjasminegreentea@users.noreply.github.com>
Signed-off-by: Raihan <36995715+drinkingjasminegreentea@users.noreply.github.com>
Signed-off-by: Raihan <36995715+drinkingjasminegreentea@users.noreply.github.com>
stevehipwell
left a comment
There was a problem hiding this comment.
Thanks for the PR @drinkingjasminegreentea but I have a couple of major issues with the approach. Firstly it would introduce a significant breaking change and for this chart, IMHO the YAML support needs to be an opt in feature not a wholesale replacement of the existing logic. Secondly one of the main benefits of the YAML format would be native values support but this PR treats the YAML as just a string; to do this correctly the YAML config needs to be a dict type and we need custom logic to merge in values from elsewhere in the chart values.
For reference I've started this work in my seperate FB charts at stevehipwell/helm-charts#1170 where I am making it a breaking change. I've not taken this further given the the questionable stability and status of the YAML config implementation.
|
Hey, any updates here? |
Uh oh!
There was an error while loading. Please reload this page.