Add labels to deployment of Fluent Operator#623
Open
jddcarreira wants to merge 3 commits intofluent:mainfrom
Open
Add labels to deployment of Fluent Operator#623jddcarreira wants to merge 3 commits intofluent:mainfrom
jddcarreira wants to merge 3 commits intofluent:mainfrom
Conversation
Signed-off-by: Joao Carreira <jddcarreira@gmail.com>
Signed-off-by: Joao Carreira <jddcarreira@gmail.com>
Signed-off-by: Joao Carreira <jddcarreira@gmail.com>
cc629d3 to
b154d36
Compare
|
Hi! Can we have a review of this PR please? I'm also waiting for this change. Thank you |
Author
|
Any update on this one @repeatedly @jvanzyl @azuwis ? |
Collaborator
|
Thanks @jddcarreira for your contributions. It's kind of awkward here. Current we have two places to host the charts. Can you try to raise a pull request to the https://github.com/fluent/fluent-operator/tree/master/charts/fluent-operator first? we can then sync the changes from fluent-operator repo to this helm chart repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current helm chart allows adding custom labels, although they are not fully propagated to the deployment.
This merge requests adds the already existing variable for labels to the deployment of Fluent Operator.