feat(fluentd): add StatefulSet enhancements and headless service support#638
Open
yuvalcohenrise wants to merge 3 commits intofluent:mainfrom
Open
feat(fluentd): add StatefulSet enhancements and headless service support#638yuvalcohenrise wants to merge 3 commits intofluent:mainfrom
yuvalcohenrise wants to merge 3 commits intofluent:mainfrom
Conversation
fa7f2d8 to
f0e3015
Compare
Contributor
|
Please can you rebase on the latest versions so we can bring in the updated CI? |
add support for HPA when kind is StatefulSet add support for PodDisruptionBudget Signed-off-by: yuvalcohenrise <yuval.cohen@risecodes.com>
Signed-off-by: yuvalcohenrise <yuval.cohen@risecodes.com>
Signed-off-by: yuvalcohenrise <yuval.cohen@risecodes.com>
Author
|
@patrick-stephens Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds several enhancements to the fluentd chart, primarily focused on improving StatefulSet deployments:
New Features
Headless Service Support
headlessServiceconfiguration to enable headless services for StatefulSet deploymentspod-0.fluentd-headless.namespace.svc.cluster.local)PersistentVolumeClaimRetentionPolicy Support
persistentVolumeClaimRetentionPolicyconfiguration for StatefulSetsPodDisruptionBudget (PDB) Support
pdb.yamltemplateminAvailableandmaxUnavailablesettingsHPA Support for StatefulSet
kindreference based on.Values.kindConditional Replicas for StatefulSet
replicasfield is now only set when autoscaling is disabledChanged Files
charts/fluentd/values.yamlpersistentVolumeClaimRetentionPolicy,podDisruptionBudget, andheadlessServiceconfigurationscharts/fluentd/templates/statefulset.yamlcharts/fluentd/templates/hpa.yamlcharts/fluentd/templates/pdb.yamlcharts/fluentd/templates/headless-service.yamlcharts/fluentd/README.mdExample Usage