feat: do not mark presubmit checkrun as failing if suppressed#4974
Merged
jtmcdole merged 1 commit intoflutter:mainfrom Mar 6, 2026
Merged
feat: do not mark presubmit checkrun as failing if suppressed#4974jtmcdole merged 1 commit intoflutter:mainfrom
jtmcdole merged 1 commit intoflutter:mainfrom
Conversation
towards: #180669 - Adds Redis caching of Firestore suppression documents. - Adds a summary prepend to the checkrun output for visibility. - Marks suppressed failures as neutral to avoid blocking PRs. - Updates UpdateSuppressedTest to maintain cache consistency. TODO: make this work with unified checkruns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
towards: flutter/flutter/#180669
TODO: make this work with unified checkruns