Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
I have read and understood ./docs/contributing/README.md.
This pull request introduces a new eval example project for evaluating genui against AI models. The setup is straightforward, but I've identified a few areas for improvement. My main feedback concerns code duplication for API key retrieval, which is also present in other examples. Addressing this would improve maintainability. I've also pointed out an unused asset configuration and a minor naming issue. Overall, a good start for the new evaluation project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #764
Docs: https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/use-secrets