[various] Convert plugin builds to Kotlin gradle#11172
Open
stuartmorgan-g wants to merge 35 commits intoflutter:mainfrom
Open
[various] Convert plugin builds to Kotlin gradle#11172stuartmorgan-g wants to merge 35 commits intoflutter:mainfrom
stuartmorgan-g wants to merge 35 commits intoflutter:mainfrom
Conversation
github-actions
bot
added
p: shared_preferences
p: interactive_media_ads
10 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
As a precursor to converting plugins to use Kotlin Gradle build files in #11172, this does some final standardization of the Groovy versions: - Uses `"` instead of `'` on more lines. - Uses `(...)` and `=` in places where it's optional, instead of just a space. - Uses `minSdk` instead of `minSdkVersion`. - Standardizes vertical whitespace (not necessary for the conversion, but it's something I cleaned up in that PR). This is being done as a precursor PR because I noticed that the files are mostly right on the cusp of being similar enough for git to think they are renames with changes rather than deletion and addition; some are ending up one way, and some the other. Since renames with changes make blame much more useful, I'd like to make the files more similar so that hopefully almost all of them will end up as renames with changes in that PR. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
stuartmorgan-g
requested review from
bparrishMines,
camsim99,
gmackall,
jesswrd,
mboetger,
reidbaker and
tarrinneal
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates a large number of Android plugin build files from Groovy to Kotlin DSL. The changes are mostly mechanical conversions and appear to be correct, preserving the original build logic. I've found one minor issue where a compiler option was dropped during the conversion in one of the test plugins, which I've commented on.
Comment on lines
+31
to
+35
| kotlin { | ||
| compilerOptions { | ||
| jvmTarget = JvmTarget.fromTarget(JavaVersion.VERSION_17.toString()) | ||
| } | ||
| } |
There was a problem hiding this comment.
The allWarningsAsErrors = true option was removed during the conversion to Kotlin DSL. This is an important setting to maintain code quality by treating all compiler warnings as errors. Please add it back to the compilerOptions.
kotlin {
compilerOptions {
jvmTarget = JvmTarget.fromTarget(JavaVersion.VERSION_17.toString())
allWarningsAsErrors.set(true)
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from #11169, this converts all the rest of the plugins in the repository to use Kotlin rather than Groovy for plugin build files. As with that PR, this does not change the example apps, only the plugin builds themselves.
Part of flutter/flutter#176065
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2