[camera] Regenerate iOS example with Swift#11283
Open
stuartmorgan-g wants to merge 10 commits intoflutter:mainfrom
Open
[camera] Regenerate iOS example with Swift#11283stuartmorgan-g wants to merge 10 commits intoflutter:mainfrom
stuartmorgan-g wants to merge 10 commits intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the iOS example app for camera_avfoundation to Swift, modernizing the example apps. The changes include replacing the existing Objective-C app with a fresh Swift copy, restoring RunnerTest code, updating Info.plist entries, and moving app launch plugin registration logic. Additionally, some minor test file cleanup was performed, such as removing stale references and adding missing headers. The review focuses on ensuring the correctness of the changes, particularly the migration to Swift and the restoration of testing functionality.
packages/camera/camera_avfoundation/example/ios/Runner.xcodeproj/project.pbxproj
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraPluginCreateCameraTests.swift
Show resolved
Hide resolved
|
|
||
| @testable import camera_avfoundation | ||
|
|
||
| /// Tests of `CameraPlugin` methods delegating to `FLTCam` instance |
There was a problem hiding this comment.
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraSessionPresetsTests.swift
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/PhotoCaptureTests.swift
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/PhotoCaptureTests.swift
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/PhotoCaptureTests.swift
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/PhotoCaptureTests.swift
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/SampleBufferTests.swift
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/SampleBufferTests.swift
Show resolved
Hide resolved
hellohuanlin
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the iOS example app for
camera_avfoundationto a Swift app. Rather than edit in place, this replaces the example app with a fresh copy to minimize drift from current template:flutter create --platforms=ios --org=dev.flutter .I also did some minor test file cleanup I noticed while validating everything in Xcode again:
FLTprefix (missed during Swift migrations).This is part of an overall modernization of the example apps; most packages have already been converted to Swift examples.
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2