[proposal] Notifications for triggers by kumare3 · Pull Request #414 · flyteorg/flyte-sdk

kumare3 · 2025-12-11T19:50:07Z

No description provided.

Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>

squiishyy · 2025-12-13T00:06:18Z

examples/triggers/notifications.py

+            on_phase=(
+                "FAILED",
+                "TIMED OUT",
+            ),


Is there some way to pass in list of enums instead of strings?

enums we avoid as you have to import so we use literals. these are literals

I can make them enums, no problem though

I am thinking, if we do this, then all phases will be in a common model for all of user facing apis and we can then use them everywhere

Can we re-use the phase literals as defined here? https://github.com/flyteorg/flyte-sdk/blob/main/src/flyte/remote/_run.py#L21-L23 (i.e. lower-cased)

Ohh ya - but I think I will
Move them to a common place

I moved them to a common place now, will update PR

Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>

iaroslav-ciupin · 2025-12-15T17:02:49Z

examples/triggers/notifications.py

+    name="hourly",
+    auto_activate=True,
+    automation=flyte.Cron("* * * * *"),
+    notifications=flyte.notify.Slack(


Is this saying that notifications will ONLY be sent for failed triggered runs?
What if I want to configure notifications even for runs that are manually created(via Web or CLI). Lets say, its an important workflow on prod domain and everybody in the team must be aware about failures even If I'm the author of the run and I saw the failure.

Are the notifications only attached to individual tasks?
do we want to allow configuring notifications for entire domain(prod), project+domain(<important_project> on prod) or maybe project+domain+task_regex?
What if I want to configure your notifications once, without repeating same configs on multiple task definitions?

As a follow up for 1 and 2, should notifications be a separate SDK entity in which you can configure multiple matching criteria independently? project, domain, task_regex, triggered vs manual, maybe others in future?

I would like it to be possible to notify at the organization, domain, and project-domain levels as this is a frequent request we got in v1 over the past few years. People want to be able to notify on any failure in the prod domain, for instance. I don't know that this makes sense to include in the SDK, though - I feel like this makes sense in the UI for sure, as well as the API/CLI (which can be used by a terraform provider).

+1 to Votta. With scoping for now to be triggered runs only

given that we really only do email for now even for slack, should we just do email?

iaroslav-ciupin · 2025-12-15T17:22:34Z

examples/triggers/notifications.py

+        ),
+        flyte.notify.Webhook(
+            on_phase="SUCCEEDED",
+            headers={"Content-Type": "application/json"},


should webhooks URLs be accessible without any auth credentials? if not, what should be the DevUX for customer to provide credentials for his webhook securely to Union? and I guess Union notifications service(workers) should be able to read those secure credentials during the notification delivery.

same question about Slack API. Not familiar with it, but do we need some token to hit the API? who and how will provide this token to us?

I think we will stick to unauthenticated webhooks (or more specifically, webhooks which embed the auth into the webhook itself)

iaroslav-ciupin · 2025-12-15T17:33:48Z

examples/triggers/notifications.py

+        flyte.notify.Email(
+            on_phase="SUCCEEDED",
+            subject="Hello world! from {task.name}",
+            body="Hello world! from {task.name}",


just want to double check the DevUX here: if I want the same email template to be sent for all my failed tasks with some variables like <task_name>, <domain>, <project>, etc. , I can simply store this template in a Python variable, and then re-use it in all Email notification configs?
not sure what email provider are we going to use or if its critical right now, but, for example, AWS SES supports both sending raw emails with entire HTML body and sending emails with template id, that refers to previously uploaded template.

Just render on client side. As this may change all the time

Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>

wild-endeavor

have we tried the slack notification webhook? i know for v1 everything was done through email - will the webhook url ever need any templating?

wild-endeavor · 2026-03-02T18:21:47Z

examples/triggers/notifications.py

+    name="hourly",
+    auto_activate=True,
+    automation=flyte.Cron("* * * * *"),
+    notifications=flyte.notify.Slack(


given that we really only do email for now even for slack, should we just do email?

wild-endeavor · 2026-03-02T18:22:51Z

examples/triggers/notifications.py

+        on_phase=ActionPhase.FAILED,
+        webhook_url="https://webhook.site/",
+        message="Hello world! from {task.name}",
+        blocks=(


can we drop this for now, until customers ask? just wary of supporting too many features out of the gate, and then we have to mark things deprecated if they ever change.

wild-endeavor · 2026-03-02T18:23:00Z

examples/triggers/notifications.py

+    auto_activate=True,
+    automation=flyte.Cron("* * * * *"),
+    notifications=flyte.notify.Slack(
+        on_phase=ActionPhase.FAILED,


should we just call this on?

wild-endeavor · 2026-03-02T18:23:50Z

examples/triggers/notifications.py

+    automation=flyte.Cron("* * * * *"),
+    notifications=flyte.notify.Slack(
+        on_phase=ActionPhase.FAILED,
+        webhook_url="https://webhook.site/",


can we change the name maybe so that it doesn't cause any confusion with the Webhook notification? slack_endpoint or service_url or something?

wild-endeavor · 2026-03-02T18:25:10Z

src/flyte/notify/__init__.py

+Supported Phases:
+    - "SUCCEEDED": Task completed successfully
+    - "FAILED": Task failed
+    - "TIMED_OUT": Task timed out


will lease failovers count here?

not right now only terminal. I think we should also drop support for Queued and Running, cc @iaroslav-ciupin / @EngHabu

I don't know what is a lease failover.
I think the original requirements was to ONLY send notifications for terminal root actions(when entire run completes).

Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>

iaroslav-ciupin · 2026-03-03T19:28:10Z

@kumare3 I started this IDL PR with my proposal for backend API https://github.com/flyteorg/flyte/pull/6946/changes
This SDK proposal should be possible to implement with one-off notification settings stored directly in RunSpec.
Please also refer to implementation roadmap here

[proposal] Notifications for triggers

7eb63dd

Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>

squiishyy reviewed Dec 13, 2025

View reviewed changes

kumare3 added 2 commits December 12, 2025 17:22

Merge branch 'main' into notifications

6b1dca2

Updated removed slack channel

dbbed6b

Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>

kumare3 marked this pull request as draft December 13, 2025 01:57

iaroslav-ciupin reviewed Dec 15, 2025

View reviewed changes

kumare3 added 2 commits December 25, 2025 17:12

Merge branch 'main' into notifications

aaf37a0

Updated phases and unit tests

74a175b

Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>

wild-endeavor previously approved these changes Mar 2, 2026

View reviewed changes

kumare3 added 2 commits March 2, 2026 21:39

Merge branch 'main' into notifications

b24a755

notifications on flyte.run and clean up with tests

e98c7dd

Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>

kumare3 dismissed wild-endeavor’s stale review via e98c7dd March 3, 2026 06:04

kumare3 added 3 commits March 3, 2026 14:50

Merge branch 'main' into notifications

2e44295

Merge branch 'main' into notifications

378c47e

Merge branch 'main' into notifications

6034e2d

Conversation

kumare3 commented Dec 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iaroslav-ciupin Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iaroslav-ciupin Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wild-endeavor left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iaroslav-ciupin commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

iaroslav-ciupin Dec 15, 2025 •

edited

Loading

iaroslav-ciupin Dec 15, 2025 •

edited

Loading