-
Notifications
You must be signed in to change notification settings - Fork 29
adding progress bar for asyncio operations #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
debasisdwivedy
wants to merge
1
commit into
flyteorg:main
Choose a base branch
from
debasisdwivedy:add_tqdm_for_async_operation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| from tqdm.asyncio import tqdm | ||
|
|
||
| import flyte | ||
|
|
||
| env = flyte.TaskEnvironment( | ||
| name="hello_v2_with_progress_bar", | ||
| ) | ||
|
|
||
|
|
||
| @env.task() | ||
| async def hello_worker(id: int) -> str: | ||
| ctx = flyte.ctx() | ||
| assert ctx is not None | ||
| return f"hello, my id is: {id} and I am being run by Action: {ctx.action}" | ||
|
|
||
|
|
||
| @env.task() | ||
| async def hello_driver(ids: list[int] = [1, 2, 3]) -> list[str]: | ||
| coros = [] | ||
| with flyte.group("fanout-group"): | ||
| for id in ids: | ||
| coros.append(hello_worker(id)) | ||
|
|
||
| vals = await tqdm.gather(*coros,desc="Running Tasks") | ||
|
|
||
| return vals | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| flyte.init_from_config() | ||
|
|
||
| run = flyte.run(hello_driver) | ||
| print(run.name) | ||
| print(run.url) | ||
| run.wait() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| import asyncio | ||
| from tqdm.asyncio import tqdm | ||
| import hashlib | ||
| import os | ||
| import typing | ||
|
|
@@ -234,7 +235,7 @@ async def upload_dir(dir_path: Path, verify: bool = True, prefix: str | None = N | |
| if file.is_file(): | ||
| uploaded_files.append(_upload_single_file(cfg, file, verify=verify, basedir=prefix)) | ||
|
|
||
| urls = await asyncio.gather(*uploaded_files) | ||
| urls = await tqdm.gather(*uploaded_files,desc=f"Uploading files to {dir_path}") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rendering this becomes a big challenge - we need to think about the rendering and overhead architecture of runtime vs cli |
||
| native_url = urls[0][1] # Assuming all files are uploaded to the same prefix | ||
| # native_url is of the form s3://my-s3-bucket/flytesnacks/development/{prefix}/source/empty.md | ||
| uri = native_url.split(prefix)[0] | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really prefer if you use rich progress if at all. No new dependencies please