Draft
Conversation
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
- Extract _AirflowTaskMixin to DRY shared behavior (dependency arrows, ExecutorSafeguard workaround, common init) between task classes - Rename classes for clarity: AirflowRawContainerTask -> AirflowShellTask, AirflowFunctionTask -> AirflowPythonFunctionTask, AirflowTaskResolver -> AirflowPythonTaskResolver - Break FlyteDAG.build() into smaller methods: _build_downstream_map(), _find_caller_module(), _create_dag_entry() - Replace global statement with module-level _state dict - Remove unused imports, dead code (_downstream_flyte_tasks, commented-out params), and replace print() with logger.debug() - Consolidate two iteration loops in build() into one - Update README with current API and quick-start example Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Kevin Su <pingsutw@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flyteplugins-airflow) that monkey-patchesairflow.DAGandBaseOperatorto transparently convert standard Airflow DAG definitions into runnable Flyte tasks_AirflowTaskMixinto DRY shared behavior (dependency arrows, ExecutorSafeguard workaround) betweenAirflowShellTaskandAirflowPythonFunctionTaskFlyteDAG.build()into smaller focused methods (_build_downstream_map(),_find_caller_module(),_create_dag_entry())globalstatements with a module-level_statedictTest plan
import flyteplugins.airflow.tasktriggers patches correctly