Override Ray config with fields for namespace, service account, pod resources#4170
Closed
guozhen-la wants to merge 1 commit intoflyteorg:masterfrom
Closed
Override Ray config with fields for namespace, service account, pod resources#4170guozhen-la wants to merge 1 commit intoflyteorg:masterfrom
guozhen-la wants to merge 1 commit intoflyteorg:masterfrom
Conversation
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
e3888f3 to
3cbc269
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4170 +/- ##
==========================================
+ Coverage 54.59% 59.54% +4.94%
==========================================
Files 178 216 +38
Lines 16038 15938 -100
==========================================
+ Hits 8756 9490 +734
+ Misses 6568 5473 -1095
- Partials 714 975 +261
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2 tasks
Contributor
|
Cleaning stale PRs. Please reopen if you wan to discuss this further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreates PR that was moved in the monorepo
see #4136
As per our conversation with the Union AI, we are making the following changes to the Ray plugin to enable more parameters to be configurable on the user side using flytekit SDK.
see: flyteorg/flyteidl#429
Tracking issue
Describe your changes
Check all the applicable boxes
Screenshots
Note to reviewers