[Monorepo] Enable proxy-authorization in admin client#4189
Merged
eapolinario merged 19 commits intomasterfrom Oct 11, 2023
Merged
[Monorepo] Enable proxy-authorization in admin client#4189eapolinario merged 19 commits intomasterfrom
eapolinario merged 19 commits intomasterfrom
Conversation
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
…ture Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
…ials future Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
…future Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
…efore Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
…uthorization' into monorepo--importing-flyteidl-437 Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4189 +/- ##
==========================================
+ Coverage 59.45% 59.94% +0.49%
==========================================
Files 638 569 -69
Lines 54134 41049 -13085
==========================================
- Hits 32183 24607 -7576
+ Misses 19404 14053 -5351
+ Partials 2547 2389 -158
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
8 tasks
Contributor
Author
|
@fg91 , can you fix the error in single-binary propeller? It repros locally, just run |
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
952d2f5 to
d2013e9
Compare
wild-endeavor
approved these changes
Oct 11, 2023
andrewwdye
added a commit
that referenced
this pull request
Oct 12, 2023
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
2 tasks
5 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR imports flyteorg/flyteidl#437 into the monorepo.
Original description
Part of an effort to integrate Flyte with GCP Identity Aware Proxy, see #3965.
Allows the flyteidl admin client to sent a
"proxy-authorization"header with every request to flyteadmin. Tokens for this header are created using an external command which is configured via the newproxyCommandconfig entry.Same logic as was introduced in
flytekitin flyteorg/flytekit#1787.I replicated the existing logic in
MaterializeCredentialsandNewAuthInterceptorfor the second token. The external command is called a single time perflytectlcall.Tracking Issue
Closes #3965
Check all the applicable boxes
Screenshots
Note to reviewers