[FEAT] add driver/executor pod in Spark by machichima · Pull Request #3016 · flyteorg/flytekit

machichima · 2024-12-20T15:16:28Z

Tracking issue

Why are the changes needed?

This PR update the flytekit-spark package to configure driver pod and executor pod separately using PodTemplate. Enable setting the separate primary_container_name for driver/executor pod separate from the task podTemplate.

What changes were proposed in this pull request?

Add driver_pod and executor_pod field with type PodTemplate in SparkJob.

How was this patch tested?

Adding unit test test_spark_driver_executor_podSpec
Modified the @task for hello_spark function in my_spark example here as follow to set the driver_pod and executor_pod.

custom_image = ImageSpec(
    python_version="3.9",
    registry="ghcr.io/machichima",
    packages=["flytekitplugins-spark"],
)


driver_pod = PodTemplate(
    labels={"lKeyA_d": "lValA", "lKeyB_d": "lValB"},
    annotations={"aKeyA_d": "aValA", "aKeyB_d": "aValB"},
    primary_container_name="driver-primary",
    pod_spec=V1PodSpec(
        containers=[
            V1Container(
                name="driver-primary",
                image="ghcr.io/machichima",
                command=["echo"],
                args=["wow"],
                env=[V1EnvVar(name="x/custom-driver", value="driver")],
            ),
            V1Container(
                name="driver-primary",
                image="ghcr.io/machichima",
                command=["echo"],
                args=["wow"],
                # resources=V1ResourceRequirements(requests={"memory": "1000M"}),
                env=[V1EnvVar(name="x/custom-driver-1", value="driver-1")],
            ),
            V1Container(
                name="not-primary",
                command=["echo"],
                args=["not_primary"],
            ),
        ],
        tolerations=[
            V1Toleration(
                key="x/custom-driver",
                operator="Equal",
                value="foo-driver",
                effect="NoSchedule",
            ),
        ],
    ),
)

executor_pod = PodTemplate(
    labels={"lKeyA_e": "lValA", "lKeyB_e": "lValB"},
    annotations={"aKeyA_e": "aValA", "aKeyB_e": "aValB"},
    primary_container_name="executor-primary",
    pod_spec=V1PodSpec(
        containers=[
            V1Container(
                name="executor-primary",
                image="ghcr.io/machichima",
                command=["echo"],
                args=["wow"],
                env=[V1EnvVar(name="x/custom-executor", value="executor")],
            ),
            V1Container(
                name="not-primary",
                command=["echo"],
                args=["not_primary"],
            ),
        ],
        tolerations=[
            V1Toleration(
                key="x/custom-executor",
                operator="Equal",
                value="foo-executor",
                effect="NoSchedule",
            ),
        ],
    ),
)

@task(
    cache_version="0.1.0",
    task_config=Spark(
        # This configuration is applied to the Spark cluster
        spark_conf={
            "spark.executor.cores": "1",
            "spark.executor.instances": "2",
            "spark.driver.cores": "1",
            "spark.jars": "https://storage.googleapis.com/hadoop-lib/gcs/gcs-connector-hadoop3-latest.jar",
        },
        driver_pod=driver_pod,
        executor_pod=executor_pod,
    ),
    # limits=Resources(cpu="50m", mem="2000M"),
    container_image=custom_image,
    pod_template=PodTemplate(
        labels={"lKeyA": "lValA", "lKeyB": "lValB"},
        annotations={"aKeyA": "aValA", "aKeyB": "aValB"},
        pod_spec=V1PodSpec(
            containers=[
                V1Container(
                    name="primary",
                    image=custom_image,
                    command="echo",
                    args=["wow"],
                ),
            ],
            tolerations=[
                V1Toleration(
                    key="x/custom",
                    operator="Equal",
                    value="foo",
                    effect="NoSchedule",
                ),
            ],
        ),
    ),
)

Verify the pods have Tolerations and EnvVar set.

❯ kubectl describe sparkapplications.sparkoperator.k8s.io -n flytesnacks-development acjqns8twhn6sg5l6dnj-n0-0 | grep "Tolerations:" -A 8
    Tolerations:
      Effect:    NoSchedule
      Key:       x/custom
      Operator:  Equal
      Value:     foo
      Effect:    NoSchedule
      Key:       x/custom-driver
      Operator:  Equal
      Value:     foo-driver
--
    Tolerations:
      Effect:             NoSchedule
      Key:                x/custom
      Operator:           Equal
      Value:              foo
      Effect:             NoSchedule
      Key:                x/custom-executor
      Operator:           Equal
      Value:              foo-executor

❯ kubectl describe sparkapplications.sparkoperator.k8s.io -n flytesnacks-development acjqns8twhn6sg5l6dnj-n0-0 | grep "Name:        x/custom-driver" -A 1
      Name:        x/custom-driver
      Value:       driver

❯ kubectl describe sparkapplications.sparkoperator.k8s.io -n flytesnacks-development acjqns8twhn6sg5l6dnj-n0-0 | grep "Name:        x/custom-executor" -A 1
      Name:        x/custom-executor
      Value:       executor

Setup process

Screenshots

Check all the applicable boxes

I updated the documentation accordingly.
All new and existing tests passed.
All commits are signed-off.

Related PRs

flyteorg/flyte#6085

Docs link

Summary by Bito

Enhanced flytekit-spark package by implementing configurable driver and executor pod support through PodTemplate. Added driver_pod and executor_pod fields to SparkJob model with primary_only flag for pod spec serialization. The implementation includes type hint updates from K8sPod to PodTemplate, parameter order modifications, and improved SparkSession cleanup in tests. This enables granular control and customization of labels, annotations, containers, and tolerations for both driver and executor pods.

Unit tests added: True

Estimated effort to review (1-5, lower is better): 2

welcome · 2024-12-20T15:16:31Z

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
Sign off your commits (Reference: DCO Guide).

Signed-off-by: machichima <nary12321@gmail.com>

flyte-bot · 2025-01-18T14:10:09Z

Code Review Agent Run #3c7587

Actionable Suggestions - 2

plugins/flytekit-spark/flytekitplugins/spark/models.py - 1
- Missing pod config in overrides method · Line 79-80
plugins/flytekit-spark/flytekitplugins/spark/task.py - 1
- Consider adding return type hints · Line 188-188

Additional Suggestions - 1

plugins/flytekit-spark/tests/test_spark_task.py - 1
- Consider single line function call · Line 151-153

Review Details

Files reviewed - 3 · Commit Range: 8cc081d..7793398
- plugins/flytekit-spark/flytekitplugins/spark/models.py
- plugins/flytekit-spark/flytekitplugins/spark/task.py
- plugins/flytekit-spark/tests/test_spark_task.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

AI Code Review powered by

flyte-bot · 2025-01-18T14:15:29Z

Changelist by Bito

This pull request implements the following key changes.

Key Change	Files Impacted
Feature Improvement - Enhanced Spark Pod Configuration Support	- `utils.py` - Added Spark-specific pod template serialization logic - `models.py` - Added driver_pod and executor_pod fields to SparkJob model - `task.py` - Implemented driver and executor pod configuration in Spark task - `test_spark_task.py` - Added comprehensive tests for driver/executor pod configuration

plugins/flytekit-spark/flytekitplugins/spark/models.py

flyte-bot · 2025-01-18T14:15:32Z

plugins/flytekit-spark/flytekitplugins/spark/task.py


        return MessageToDict(job.to_flyte_idl())

+    def to_k8s_pod(self, pod_template: PodTemplate | None, settings: SerializationSettings) -> K8sPod | None:


Consider adding return type hints

Consider adding type hints for the return value of _get_container() in the to_k8s_pod() method. The method appears to use this internal method but its return type is not clearly specified in the type hints.

Code suggestion

Check the AI-generated fix before applying

Suggested change

def to_k8s_pod(self, pod_template: PodTemplate | None, settings: SerializationSettings) -> K8sPod | None:

def to_k8s_pod(self, pod_template: PodTemplate | None, settings: SerializationSettings) -> K8sPod | None:

from flytekit.models import task as _task_model

_get_container: Callable[..., _task_model.Container] = self._get_container

Code Review Run #3c7587

Is this a valid issue, or was it incorrectly flagged by the Agent?

it was incorrectly flagged

Take the container with name set in driver/executor podTempalte primary_container_name Signed-off-by: machichima <nary12321@gmail.com>

codecov · 2025-01-19T07:54:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.67%. Comparing base (22acc2c) to head (30cff7c).
Report is 15 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (22acc2c) and HEAD (30cff7c). Click for more details.

HEAD has 3 uploads less than BASE

Flag BASE (22acc2c) HEAD (30cff7c)

25 22

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #3016       +/-   ##
===========================================
- Coverage   80.01%   46.67%   -33.34%     
===========================================
  Files         318      319        +1     
  Lines       27075    26695      -380     
  Branches     2779     2806       +27     
===========================================
- Hits        21663    12461     -9202     
- Misses       4647    14123     +9476     
+ Partials      765      111      -654

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

flyte-bot · 2025-01-19T08:53:36Z

Code Review Agent Run #f512d4

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: 7793398..b21d1e3
- flytekit/core/utils.py
- plugins/flytekit-spark/flytekitplugins/spark/task.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

AI Code Review powered by

Exclude those in the podTemplate of spark driver/executor pod Signed-off-by: machichima <nary12321@gmail.com>

Signed-off-by: machichima <nary12321@gmail.com>

flyte-bot · 2025-01-19T11:43:37Z

Code Review Agent Run #27c6ae

Actionable Suggestions - 2

flytekit/core/utils.py - 1
- Consider extracting Spark container logic · Line 181-184
plugins/flytekit-spark/tests/test_spark_task.py - 1
- Consider proper typing instead of ignoring · Line 370-378

Review Details

Files reviewed - 3 · Commit Range: b21d1e3..1b7c1c9
- flytekit/core/utils.py
- plugins/flytekit-spark/flytekitplugins/spark/task.py
- plugins/flytekit-spark/tests/test_spark_task.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

AI Code Review powered by

flyte-bot · 2025-01-19T11:47:13Z

flytekit/core/utils.py

+            if task_type != "spark":
+                # for spark driver/executor, do not use the command and args from task podTemplate
+                container.command = primary_container.command
+                container.args = primary_container.args


Consider extracting Spark container logic

Consider extracting the Spark-specific container command/args logic into a separate helper function to improve code organization and readability. The current nested if condition makes the code harder to follow.

Code suggestion

Check the AI-generated fix before applying

- if task_type != "spark": - # for spark driver/executor, do not use the command and args from task podTemplate - container.command = primary_container.command - container.args = primary_container.args + if _should_copy_container_command_args(task_type): + container.command = primary_container.command + container.args = primary_container.args + def _should_copy_container_command_args(task_type: str) -> bool: + # for spark driver/executor, do not use the command and args from task podTemplate + return task_type != "spark"

Code Review Run #27c6ae

Is this a valid issue, or was it incorrectly flagged by the Agent?

it was incorrectly flagged

flyte-bot · 2025-01-19T11:47:14Z

plugins/flytekit-spark/tests/test_spark_task.py

+        pod_spec=driver_pod_spec_dict_remove_None,  # type: ignore
+    )
+
+    target_executor_k8sPod = K8sPod(
+        metadata=K8sObjectMetadata(
+            labels={"lKeyA_e": "lValA", "lKeyB_e": "lValB"},
+            annotations={"aKeyA_e": "aValA", "aKeyB_e": "aValB"},
+        ),
+        pod_spec=executor_pod_spec_dict_remove_None,  # type: ignore


Consider proper typing instead of ignoring

Consider removing the # type: ignore comments and properly typing the pod_spec parameter to match the expected type.

Code suggestion

Check the AI-generated fix before applying

- pod_spec=driver_pod_spec_dict_remove_None, # type: ignore + pod_spec=V1PodSpec(**driver_pod_spec_dict_remove_None), @@ -378,1 +378,1 @@ - pod_spec=executor_pod_spec_dict_remove_None, # type: ignore + pod_spec=V1PodSpec(**executor_pod_spec_dict_remove_None),

Code Review Run #27c6ae

Is this a valid issue, or was it incorrectly flagged by the Agent?

it was incorrectly flagged

Signed-off-by: machichima <nary12321@gmail.com>

flyte-bot · 2025-01-19T14:23:37Z

Code Review Agent Run #41dd0b

Actionable Suggestions - 1

plugins/flytekit-spark/tests/test_spark_task.py - 1
- Consider extracting duplicate SparkSession cleanup code · Line 53-59

Review Details

Files reviewed - 2 · Commit Range: 1b7c1c9..167a390
- plugins/flytekit-spark/flytekitplugins/spark/task.py
- plugins/flytekit-spark/tests/test_spark_task.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

AI Code Review powered by

Signed-off-by: machichima <nary12321@gmail.com>

flyte-bot · 2025-02-05T14:49:01Z

Code Review Agent Run Status

Limitations and other issues: ❌ Failure - Bito Code Review Agent didn't review this pull request automatically because it exceeded the size limit. No action is needed if you didn't intend for the agent to review it. Otherwise, you can initiate the review by typing /review in a comment below.

pingsutw · 2025-02-10T20:24:15Z

flytekit/core/utils.py


-            container.command = primary_container.command
-            container.args = primary_container.args
+            if task_type != "spark":


We can use this function to create a k8sPod from podTemplate.

flytekit/flytekit/models/task.py

Lines 1079 to 1083 in 2ef875c

def from_pod_template(cls, pod_template: "PodTemplate") -> "K8sPod":

return cls(

metadata=K8sObjectMetadata(labels=pod_template.labels, annotations=pod_template.annotations),

pod_spec=ApiClient().sanitize_for_serialization(pod_template.pod_spec),

)

Thanks for the information! I changed using this function and remove task_type in _serialize_pod_spec

Signed-off-by: machichima <nary12321@gmail.com>

flyte-bot · 2025-02-12T14:57:54Z

Code Review Agent Run Status

Limitations and other issues: ❌ Failure - Bito Code Review Agent didn't review this pull request automatically because it exceeded the size limit. No action is needed if you didn't intend for the agent to review it. Otherwise, you can initiate the review by typing /review in a comment below.

davidmirror-ops · 2025-02-13T10:39:40Z

@machichima any chance we could expand the Spark plugin docs to include your example?

machichima · 2025-02-13T14:07:42Z

@machichima any chance we could expand the Spark plugin docs to include your example?

Sure! Is it ok to add the pod_template settings into the existing examples/k8s_spark_plugin/k8s_spark_plugin/pyspark_pi.py? Or should I create a new example file. I'll also update the docs for sure!

…-driver-executor-podtemplate Signed-off-by: machichima <nary12321@gmail.com>

Signed-off-by: machichima <nary12321@gmail.com>

flyte-bot · 2025-02-23T09:30:56Z

Code Review Agent Run Status

Limitations and other issues: ❌ Failure - Bito Code Review Agent didn't review this pull request automatically because it exceeded the size limit. No action is needed if you didn't intend for the agent to review it. Otherwise, you can initiate the review by typing /review in a comment below.

machichima · 2025-02-23T10:12:18Z

The docs is updated here: flyteorg/flytesnacks#1782

pingsutw · 2025-03-13T15:16:07Z

plugins/flytekit-spark/flytekitplugins/spark/task.py


        return MessageToDict(job.to_flyte_idl())

+    def to_k8s_pod(self, pod_template: Optional[PodTemplate] = None) -> Optional[K8sPod]:


We can use this function instead?

I use this function because we need to also check if the primary container name set in driver/executor is the same as in task, if not, a warning should be raised.

This function use from_pod_template to create k8spod in the end

pingsutw · 2025-03-13T15:16:21Z

plugins/flytekit-spark/tests/test_spark_task.py

+# @pytest.fixture(scope="function")
+# def reset_spark_session() -> None:
+#     pyspark.sql.SparkSession.builder.getOrCreate().stop()
+#     yield
+#     pyspark.sql.SparkSession.builder.getOrCreate().stop()
+


Suggested change

# @pytest.fixture(scope="function")

# def reset_spark_session() -> None:

# pyspark.sql.SparkSession.builder.getOrCreate().stop()

# yield

# pyspark.sql.SparkSession.builder.getOrCreate().stop()

Signed-off-by: machichima <nary12321@gmail.com>

flyte-bot · 2025-03-13T16:32:55Z

Code Review Agent Run Status

Limitations and other issues: ❌ Failure - Bito Code Review Agent didn't review this pull request automatically because it exceeded the size limit. No action is needed if you didn't intend for the agent to review it. Otherwise, you can initiate the review by typing /review in a comment below.

Signed-off-by: machichima <nary12321@gmail.com> Signed-off-by: Atharva <atharvakulkarni172003@gmail.com>

machichima requested review from Future-Outlier, cosmicBboy, eapolinario, kumare3, pingsutw, samhita-alla, thomasjpfan and wild-endeavor as code owners December 20, 2024 15:16

machichima mentioned this pull request Dec 20, 2024

[FEAT] add driverPod/executorPod in Spark flyteorg/flyte#6085

Merged

3 tasks

machichima force-pushed the 4105-spark-driver-executor-podtemplate branch from 2ff8b9a to af03383 Compare December 20, 2024 17:22

feat: add driver/executor pod in Spark

8cc081d

Signed-off-by: machichima <nary12321@gmail.com>

Future-Outlier assigned pingsutw Jan 13, 2025

feat: convert driver/exec podTemplate to k8spod

7793398

Signed-off-by: machichima <nary12321@gmail.com>

machichima force-pushed the 4105-spark-driver-executor-podtemplate branch from af03383 to 7793398 Compare January 18, 2025 13:04

flyte-bot reviewed Jan 18, 2025

View reviewed changes

plugins/flytekit-spark/flytekitplugins/spark/models.py Show resolved Hide resolved

flyte-bot reviewed Jan 18, 2025

View reviewed changes

feat: pyspark take the primary container only

b21d1e3

Take the container with name set in driver/executor podTempalte primary_container_name Signed-off-by: machichima <nary12321@gmail.com>

machichima added 2 commits January 19, 2025 18:33

feat: exclude cmd/args from task podTemplate

00d0c3a

Exclude those in the podTemplate of spark driver/executor pod Signed-off-by: machichima <nary12321@gmail.com>

test: for custom driver/executor podTemplate

1b7c1c9

Signed-off-by: machichima <nary12321@gmail.com>

flyte-bot reviewed Jan 19, 2025

View reviewed changes

machichima added 2 commits January 19, 2025 21:14

fix: test and type

32f6aa9

Signed-off-by: machichima <nary12321@gmail.com>

fix: lint and docs

167a390

Signed-off-by: machichima <nary12321@gmail.com>

fix: lint docstring err

d6b752b

Signed-off-by: machichima <nary12321@gmail.com>

machichima force-pushed the 4105-spark-driver-executor-podtemplate branch from c6a8f94 to d6b752b Compare February 5, 2025 14:14

test: fix spark test

900113f

Signed-off-by: machichima <nary12321@gmail.com>

pingsutw reviewed Feb 10, 2025

View reviewed changes

machichima added 3 commits February 12, 2025 21:50

fix: use K8sPod.from_pod_template for driver/executor

68bef7d

Signed-off-by: machichima <nary12321@gmail.com>

test: update test

5a12025

Signed-off-by: machichima <nary12321@gmail.com>

lint

30cff7c

Signed-off-by: machichima <nary12321@gmail.com>

davidmirror-ops requested a review from pingsutw February 13, 2025 10:35

davidmirror-ops mentioned this pull request Feb 13, 2025

Nominate @machichima as Committer flyteorg/community#35

Closed

machichima added 2 commits February 23, 2025 14:49

Merge branch 'master' of github.com:flyteorg/flytekit into 4105-spark…

e17ee57

…-driver-executor-podtemplate Signed-off-by: machichima <nary12321@gmail.com>

feat: warning if primary container name differ from @task

7f4e00b

Signed-off-by: machichima <nary12321@gmail.com>

machichima force-pushed the 4105-spark-driver-executor-podtemplate branch from 01bc98a to 7f4e00b Compare February 23, 2025 08:36

machichima mentioned this pull request Feb 23, 2025

Update spark example for customising driver and executor pod template flyteorg/flytesnacks#1782

Open

pingsutw reviewed Mar 13, 2025

View reviewed changes

machichima added 2 commits March 13, 2025 23:26

style: remove commented code

2541e26

Signed-off-by: machichima <nary12321@gmail.com>

Merge branch 'master' into 4105-spark-driver-executor-podtemplate

110febe

Signed-off-by: machichima <nary12321@gmail.com>

pingsutw approved these changes Mar 13, 2025

View reviewed changes

github-project-automation bot moved this from Cold PRs to Approved yet unmerged PRs in Flyte Issues/PRs maintenance Mar 13, 2025

pingsutw merged commit 253834e into flyteorg:master Mar 13, 2025
111 of 112 checks passed

github-project-automation bot moved this from In review to Done in OSS Contributions Mar 13, 2025

github-project-automation bot moved this from Approved yet unmerged PRs to Done in Flyte Issues/PRs maintenance Mar 13, 2025

davidmirror-ops mentioned this pull request Mar 19, 2025

[BUG] Spark Pod Template Resources not getting applied flyteorg/flyte#6348

Open

2 tasks

Atharva1723 pushed a commit to Atharva1723/flytekit that referenced this pull request Oct 5, 2025

[FEAT] add driver/executor pod in Spark (flyteorg#3016)

296247e

Signed-off-by: machichima <nary12321@gmail.com> Signed-off-by: Atharva <atharvakulkarni172003@gmail.com>


		return MessageToDict(job.to_flyte_idl())

		def to_k8s_pod(self, pod_template: PodTemplate \| None, settings: SerializationSettings) -> K8sPod \| None:

	def from_pod_template(cls, pod_template: "PodTemplate") -> "K8sPod":
	return cls(
	metadata=K8sObjectMetadata(labels=pod_template.labels, annotations=pod_template.annotations),
	pod_spec=ApiClient().sanitize_for_serialization(pod_template.pod_spec),
	)


		return MessageToDict(job.to_flyte_idl())

		def to_k8s_pod(self, pod_template: Optional[PodTemplate] = None) -> Optional[K8sPod]:

Conversation

machichima commented Dec 20, 2024 • edited by flyte-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

Related PRs

Docs link

Summary by Bito

Uh oh!

welcome bot commented Dec 20, 2024

Uh oh!

flyte-bot commented Jan 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #3c7587

Uh oh!

flyte-bot commented Jan 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist by Bito

Uh oh!

Uh oh!

flyte-bot Jan 18, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

flyte-bot commented Jan 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #f512d4

Uh oh!

flyte-bot commented Jan 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #27c6ae

Uh oh!

flyte-bot Jan 19, 2025

Choose a reason for hiding this comment

Uh oh!

flyte-bot Jan 19, 2025

Choose a reason for hiding this comment

Uh oh!

flyte-bot commented Jan 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #41dd0b

Uh oh!

flyte-bot commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run Status

Uh oh!

pingsutw Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

machichima Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

flyte-bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run Status

Uh oh!

davidmirror-ops commented Feb 13, 2025

Uh oh!

machichima commented Feb 13, 2025

Uh oh!

flyte-bot commented Feb 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run Status

Uh oh!

machichima commented Feb 23, 2025

Uh oh!

pingsutw Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

machichima Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

machichima commented Dec 20, 2024 •

edited by flyte-bot

Loading

flyte-bot commented Jan 18, 2025 •

edited

Loading

flyte-bot commented Jan 18, 2025 •

edited

Loading

codecov bot commented Jan 19, 2025 •

edited

Loading

flyte-bot commented Jan 19, 2025 •

edited

Loading

flyte-bot commented Jan 19, 2025 •

edited

Loading

flyte-bot commented Jan 19, 2025 •

edited

Loading

flyte-bot commented Feb 5, 2025 •

edited

Loading

flyte-bot commented Feb 12, 2025 •

edited

Loading

flyte-bot commented Feb 23, 2025 •

edited

Loading

machichima Mar 13, 2025 •

edited

Loading

flyte-bot commented Mar 13, 2025 •

edited

Loading