This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Override Ray config with fields for namespace, service account, pod resources#386
Closed
guozhen-la wants to merge 3 commits intoflyteorg:masterfrom
Closed
Override Ray config with fields for namespace, service account, pod resources#386guozhen-la wants to merge 3 commits intoflyteorg:masterfrom
guozhen-la wants to merge 3 commits intoflyteorg:masterfrom
Conversation
added 3 commits
August 11, 2023 04:03
Signed-off-by: guozhen la <guozhenl@spotify.com>
Signed-off-by: guozhen la <guozhenl@spotify.com>
Signed-off-by: guozhen la <guozhenl@spotify.com>
Contributor
|
edit: Re-opening these PRs as the automation failed. |
Contributor
|
Hi, we are moving all Flyte development to a monorepo. In order to help the transition period, we're moving open PRs to monorepo automatically and your PR was moved to flyteorg/flyte#4136. Notice that if there are any conflicts in the resulting PR they most likely happen due to the change in the import path of the flyte components. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per our conversation with the Union AI, we are making the following changes to the Ray plugin to enable more parameters to be configurable on the user side using flytekit SDK.
see: flyteorg/flyteidl#429
- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/