-
Notifications
You must be signed in to change notification settings - Fork 38
Image comparison for testpackage outputs -> CI #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Image comparison workflow for generated plots - merging to prototype branch to get verification data generation workflows available
Get generate_reference_plots from master
Moved module loading and added environment activation for Python.
Add exit code logging to the test package script.
Log exit code after job completion in script
Made compare to use the latest verification set
Fixes to create_env.py
…r so test doesnt take 10 years to test
this caused issue before with the call lists
instead of plot output indexing being based on the function used, i.e plot_bla/BLA/00n_blablabla now it would be based on whether it was restarting/nonrestarting/multipop, i.e the lists in testpackage_definitions. So indexing inside a run could go like plot_bla/BLA/00n_list1_blabla , plot_bla/BLA/00m_list2_blablabla etc. Downside is that within a run we can have two plotfiles starting with same numbering(not same string still) and the upside is that we can now add calls to the end of the list without messing up the indexing for everything.
alhom
commented
Dec 19, 2025
pyproject.toml
Outdated
| ] | ||
| all = [ | ||
| "analysator[vtk]", | ||
| "opencv-python" |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this into a analysator[tests] optional dependency, explicitly
Hopefully it works(?)
…_workflow since it would make things easier for the older python
Universe is throwing signs for a holiday
might have issue if there exists both GCC and non GCC core version for same python version
This reverts commit 3d7fa81.
…n version finding, commented out debug line
Indexing changes to testpackage, tested manually and seems to produce the correct number of plots, did not compare as the names have changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI testing branch to be merged after propagating the actual testpackage to the test branch.