Skip to content

Conversation

@kstppd
Copy link
Contributor

@kstppd kstppd commented Jan 26, 2026

This is still a WIP PR currently only working well with ZFP and Octree compression/decompressions.

@kstppd
Copy link
Contributor Author

kstppd commented Jan 26, 2026

Hmmm I see testpackage failing because match is a python 3.10 feature I think. Do we actually need to be compatible with Python <3.10?

@alhom
Copy link
Member

alhom commented Jan 26, 2026

Hmmm I see testpackage failing because match is a python 3.10 feature I think. Do we actually need to be compatible with Python <3.10?

Python 3.6 is still the default Python3 for e.g. Lumi and Turso. A prettier elif isn't quite enough to get me to bumb us off of default Python support ;).

@kstppd
Copy link
Contributor Author

kstppd commented Jan 27, 2026

Hmmm I see testpackage failing because match is a python 3.10 feature I think. Do we actually need to be compatible with Python <3.10?

Python 3.6 is still the default Python3 for e.g. Lumi and Turso. A prettier elif isn't quite enough to get me to bumb us off of default Python support ;).

This has now been handled by reverting back to an if statement.
To add support for OCTREE I relaxed the requirement of check_population(). Now it will only check whether BLOCKVARIABLE is in the footer and not BLOCKIDS as well, since for some of the compression methods BLOCKIDS are not stored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants