Github CI fixing the slurm log printing issues #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e primary way the slurm log gets printed is via srun directly on the nodes, but if that fails (communication error for example) it tries to cat it on frontend
…er editing and cleanliness
…ure if it would be otherwise)
damn i can't get anything right today
This reverts commit a378e8f.
…e srun cat and cat on frontend fails it exits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added so if job fails it still prints the slurm log, also added so the primary way the slurm log gets printed is via srun directly on the nodes instead of frontend, but if that fails (communication error for example) it tries to cat it on frontend which may produce nothing and as such this also needs a check.