Skip to content

Added dynamical array sizing to run_compare also, additionally added … #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lassejsc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added dynamical array sizing to run_compare also, additionally added … #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/make_sbatch_job.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ if [[ $? -ne 0 ]] || [[ ! $JOBID ]]; then
echo "::error::Jobid could not be found, exiting. Exit code $?"
exit 1
fi
SACCT_LOG=$(sacct -j $JOBID -o job,state,node | grep FAILED)
SACCT_LOG=$(sacct -j $JOBID -o job,state,node,exit | grep FAILED)
if [[ $SACCT_LOG ]]; then
echo "::error::Some job failed on a node, try to take a look at the slurm log."
echo "$SACCT_LOG"
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/test_compare_images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ jobs:
ARRAY_SIZE=$MAX_ARRAY
fi
export ARRAY_SIZE=$ARRAY_SIZE

echo "ARRAY_SIZE=$ARRAY_SIZE" >> $GITHUB_OUTPUT
echo "Running $DIFFRESULT, ARRAY_SIZE $ARRAY_SIZE"
.github/workflows/make_sbatch_job.sh run_testpackage_workflow $DIFFRESULT

Expand All @@ -76,6 +78,8 @@ jobs:
export TMPDIR=$RUNNER_TEMP
module load Python/3.10.4-GCCcore-11.3.0
. CI_env/bin/activate
export ARRAY_SIZE=${{ steps.run_cl.outputs.ARRAY_SIZE }}
echo "ARRAY_SIZE $ARRAY_SIZE"
.github/workflows/make_sbatch_job.sh run_compare ${{ steps.run_cl.outputs.DIFFRESULT }}

- name: scancel dangling job upon cancellation
Expand Down