chore(test): Remove unused header includes in test files#4729
Merged
vitaut merged 1 commit intofmtlib:mainfrom Apr 6, 2026
Merged
chore(test): Remove unused header includes in test files#4729vitaut merged 1 commit intofmtlib:mainfrom
vitaut merged 1 commit intofmtlib:mainfrom
Conversation
Contributor
Author
|
The clang-format CI check is reporting an error in the I’m not entirely sure, but the error might be caused by the Fuzzer project’s default branch name being changed from #9 [5/7] RUN git clone --depth 1 --branch master |
Contributor
|
The clang-format issue is fixed in main, you can ignore lint and oss-fuzz failures. |
9c3e7ee to
88cb3a5
Compare
Contributor
Author
|
Thanks for the information. I’ve rebased to the main branch. This should resolve the Clang formatting error. If any other changes wants I'm here. |
Contributor
|
Merged, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove header includes that are not directly used in their respective translation units. Identified through manual code review assisted by
IWYU (Include What You Use).I’m not entirely familiar with the project code. For that reason, I’ve stayed out of the
includeandsrcdirectories as much as possible.I compile, test and format it using the commands below, everything seems to be working fine (All 20 test pass). However, I’ll check it in CI.
Note: I labeled this as
chorerather thanrefactorsince these changes are closer to maintenance. Happy to update the title or label if you prefer something different.Please leave a comment if there’s anything you’d like me to adjust. I’ll look into it when I have a chance.