Add log statements for every request #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
srpurani
commented
Mar 4, 2020
srpurani
commented
- FDK should log before and after a call completes. This is achieved by adding log lines to handleRequest.
- The boilerplate code in the init image should have a log message printed to serve as an example.
* FDK should log before and after a call completes. This is achieved by adding log lines to handleRequest. * The boilerplate code in the init image should have a log message printed to serve as an example.
saintarian
approved these changes
Mar 5, 2020
mrc
reviewed
Mar 6, 2020
| defer cancel() | ||
|
|
||
| logFrameHeader(r) | ||
| log.Println("Request started") |
There was a problem hiding this comment.
I don't think log.Println flushes, is this a problem? (I can see it might be, if the customer's trying to figure out why there code isn't running, but maybe it's out of scope for this change?)
Member
Author
There was a problem hiding this comment.
It appears to flush, I think the problem was in Python fdk iirc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.