Skip to content

Ensure only initialised values are serialised.#35

Open
samhocevar wants to merge 1 commit intofnuecke:masterfrom
samhocevar-forks:fix-uninitialised-memory
Open

Ensure only initialised values are serialised.#35
samhocevar wants to merge 1 commit intofnuecke:masterfrom
samhocevar-forks:fix-uninitialised-memory

Conversation

@samhocevar
Copy link
Copy Markdown

For performance reasons Lua does not initialise memory until it knows
the values will actually be used. However Eris serializes some of them
without knowing whether they have been initialised, causing harmless
(but verbose) Valgrind memory check errors.

For performance reasons Lua does not initialise memory until it knows
the values will actually be used. However Eris serializes some of them
without knowing whether they have been initialised, causing harmless
(but verbose) Valgrind memory check errors.
@samhocevar
Copy link
Copy Markdown
Author

While debugging Eris I have come across a few Valgrind warnings about uninitialised call info memory being serialised. This is harmless but does pollute error reporting when investigating issues, so I thought I’d suggest the attached changes for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant